Add capability to request fine grained DiagnosticKinds to diagnostic analyzer service #65583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analyzer service The span based APIs `IDiagnosticAnalyzerService.GetDiagnosticsForSpanAsync` and `IDiagnosticAnalyzerService.TryGetDiagnosticsForSpanAsync` can now request more fine grained diagnostics: compiler syntax, compiler semantic, analyzer syntax and analyzer semantic. Required by dotnet#65547 to move our taggers to LSP pull diagnostics
...rotocol/Features/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnosticsForSpan.cs
Outdated
Show resolved
Hide resolved
...rotocol/Features/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnosticsForSpan.cs
Outdated
Show resolved
Hide resolved
...rotocol/Features/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnosticsForSpan.cs
Outdated
Show resolved
Hide resolved
...rotocol/Features/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnosticsForSpan.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Nov 23, 2022
|
Also, please don't squash/rebase. I've merged your branch into mine :) |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The span based APIs
IDiagnosticAnalyzerService.GetDiagnosticsForSpanAsyncandIDiagnosticAnalyzerService.TryGetDiagnosticsForSpanAsynccan now request more fine grained diagnostics: compiler syntax, compiler semantic, analyzer syntax, analyzer semantic or any combination of these.Required by #65547 to move our taggers to LSP pull diagnostics