-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed prop snippet caret position #64732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This change makes sense to me. But @akhera99 should confirm in case current behavior is intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the caret there so users would be able to modify the get and set, but if it makes more sense to users to have it at the end of the property, then I'm okay with that
Considering that they are not highlighted to be modifiered, user still needs a lot of keybord/mouse actions to edit them. At the same time, as I already described above, having caret at the end of line enables the ability to quickly jump to the next line, which is really useful |
What is our current behavior? I'd prefer we preserve whatever we've shipped before so we don't end up frustrating people with a new experience that behaves differently from what they've gotten used to. Perhaps we can add a new tab-stop though at the end of the prop for people who are willing to hit tab one more time? |
Old behaviour: public [|int|] [|MyProperty|] { get; set; }$$ New behaviour before this fix: public [|int|] [|MyProperty|] {$$ get; set; } New behaviour after this fix: public [|int|] [|MyProperty|] { get; set; }$$ I guess, we can merge since I aligned new behaviour with the old one |
@DoctorKrolic thanks for the contribution! |
Fixes: #64731
@akhera99 I don't know why you've chosen that cursor position in the first place, but I have 2 arguments for this one:
Enter
and jump to new line without need to move cursor with your mouse or keyboard. At the same time I don't see any clear benifits from position you've chosen