Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider types with ref fields as managed #63209

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Consider types with ref fields as managed #63209

merged 2 commits into from
Aug 9, 2022

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Aug 4, 2022 •
edited
Loading

Fixes #63104

Relates to test plan #59194

@jcouv jcouv self-assigned this Aug 4, 2022
@jcouv jcouv marked this pull request as ready for review August 5, 2022 15:43
@jcouv jcouv requested a review from a team as a code owner August 5, 2022 15:43
@jcouv jcouv requested a review from cston August 5, 2022 15:43
@jaredpar
Copy link
Member

jaredpar commented Aug 9, 2022

@cston feedback addressed

@jaredpar jaredpar enabled auto-merge (squash) August 9, 2022 16:45
@jaredpar jaredpar merged commit e3985ed into dotnet:main Aug 9, 2022
@ghost ghost added this to the Next milestone Aug 9, 2022
@MichalPetryka MichalPetryka mentioned this pull request Aug 9, 2022
Closed
@jkotas jkotas mentioned this pull request Aug 12, 2022
Closed
cston added a commit to cston/roslyn that referenced this pull request Aug 12, 2022
@cston
Revert "Consider types with ref fields as managed (dotnet#63209)"
54a0bd9 
This reverts commit e3985ed.
cston added a commit that referenced this pull request Aug 12, 2022
@cston
Revert "Consider types with ref fields as managed (#63209)" (#63367)
76bd0d9 
This reverts commit e3985ed.
@allisonchou allisonchou mentioned this pull request Aug 16, 2022
Closed
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
@jcouv jcouv deleted the managed-types branch September 12, 2022 17:36
jcouv added a commit to jcouv/roslyn that referenced this pull request Sep 15, 2022
@jcouv
Revert "Revert "Consider types with ref fields as managed (dotnet#63209…
06ddab0 
…)" (dotnet#63367)"

This reverts commit 76bd0d9.
jcouv added a commit to jcouv/roslyn that referenced this pull request Sep 16, 2022
@jcouv
Revert "Revert "Consider types with ref fields as managed (dotnet#63209…
46e01bc 
…)" (dotnet#63367)"

This reverts commit 76bd0d9.
jcouv added a commit to jcouv/roslyn that referenced this pull request Sep 16, 2022
@jcouv
Revert "Revert "Consider types with ref fields as managed (dotnet#63209…
e40ecf2 
…)" (dotnet#63367)"

This reverts commit 76bd0d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@cston cston cston approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers New Language Feature - Ref Fields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stackalloc should be disallowed for structs with ref fields
4 participants
@jcouv @jaredpar @cston @dibarbet