New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove block on editing switch expressions #50270

Merged

davidwengier merged 14 commits into dotnet:main from davidwengier:EncSwitchExpressions

May 13, 2021

Contributor

davidwengier commented Jan 6, 2021 •

edited

Loading

Fixes #43099

Dotnet-GitSync-Bot added the Area-Compilers label

davidwengier commented

View reviewed changes

src/Compilers/CSharp/Test/Emit/PDB/PDBTests.cs Outdated Show resolved Hide resolved

tmat reviewed

View reviewed changes

src/Compilers/CSharp/Test/Emit/PDB/PDBLambdaTests.cs Show resolved Hide resolved

tmat reviewed

View reviewed changes

src/Compilers/CSharp/Test/Emit/PDB/PDBLambdaTests.cs Outdated Show resolved Hide resolved

tmat reviewed

View reviewed changes

src/EditorFeatures/CSharpTest/EditAndContinue/TopLevelEditingTests.cs Show resolved Hide resolved

tmat reviewed

View reviewed changes

src/Features/Core/Portable/EditAndContinue/EditAndContinueDiagnosticDescriptors.cs Show resolved Hide resolved

tmat reviewed

View reviewed changes

src/Compilers/CSharp/Test/Emit/PDB/PDBLambdaTests.cs Outdated Show resolved Hide resolved

davidwengier commented

View reviewed changes

src/Compilers/CSharp/Test/Emit/PDB/PDBLambdaTests.cs Outdated Show resolved Hide resolved

davidwengier mentioned this pull request

Closure info in PDB is wrong for nested switch expressions #50321

Closed

davidwengier force-pushed the EncSwitchExpressions branch from e97e165 to beda640 Compare

February 26, 2021 04:05

Contributor Author

davidwengier commented Feb 26, 2021

Rebased and updated one test now that #50301 is fixed. #50321 is still outstanding.

Base automatically changed from master to main

March 3, 2021 23:53

davidwengier added 10 commits

May 4, 2021 08:27


          Remove block on editing switch expressions

398753e


          Copy test

234ebde


          Add some simple PDB tests

41c13b0


          Remove enum value


          More tests

d68e207


          More tests of various nesting

30328f6


          Remove unused resources

73e504f


          Move tests

06dde0a


          Add a skipped test for validating lambda matching

c606bc0


          Fix tests following compiler bug fix

895d132

davidwengier force-pushed the EncSwitchExpressions branch from beda640 to 895d132 Compare

May 3, 2021 22:46


          Update tests

774d707

davidwengier marked this pull request as ready for review

May 4, 2021 05:01

davidwengier requested review from a team as code owners

May 4, 2021 05:01

cston reviewed

View reviewed changes

src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueClosureTests.cs Outdated Show resolved Hide resolved

davidwengier marked this pull request as draft

May 5, 2021 06:23


          Unskip test

73ff521

davidwengier added 2 commits

May 7, 2021 11:57


          Create some more tests to try to track down what is going on

6c57d0e


          FIx test inputs

8393d1e

davidwengier marked this pull request as ready for review

May 10, 2021 01:55

Contributor Author

davidwengier commented May 13, 2021

@tmat any other feedback?

tmat approved these changes

View reviewed changes

davidwengier merged commit 8e2e6b6 into dotnet:main

davidwengier deleted the EncSwitchExpressions branch

May 13, 2021 22:23

ghost added this to the Next milestone

RikkiGibson modified the milestones: Next, 17.0.P2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels