Ensure IServiceBroker is used on a background thread #47903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
Sep 21, 2020
Probably yes, but even if that changes it wouldn't be ready for a while and still wouldn't invalidate this change. |
This was referenced Sep 23, 2020
sharwell
added a commit
to sharwell/roslyn
that referenced
this pull request
Sep 28, 2020
Expands dotnet#47903 to other calls to GetProxyAsync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
IServiceBrokerasynchronous operations do not explicitly useConfigureAwait(false). This change ensures we callGetProxyAsync<T>from a background thread to avoid accidentally introducing a UI thread dependency in code that should not have one./cc @AArnott