Initialize FatalError handlers in VS and OOP #47554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
approved these changes
Sep 9, 2020
|
First try didn't work as expected; trying again... |
sharwell
force-pushed
the
disallow-fail
branch
2 times, most recently
from
c7cd3cf
to
eab0555
Compare
sharwell
changed the title
tmat
approved these changes
Sep 10, 2020
jaredpar
requested changes
Sep 11, 2020
Enabling telemetry in CI is a non-goal for this PR. Our intent is to enable telemetry for shipping. I'm certainly open to alternatives to fix this. |
Disable the test that hit the assert. |
sharwell
force-pushed
the
disallow-fail
branch
from
3623df6
to
3cb8921
Compare
|
@jaredpar Switched to just skip that test. May need to skip more depending on how the tests go. |
jaredpar
approved these changes
Sep 11, 2020
This listener conflicts with ThrowingTraceListener, and significantly impairs the ability to identify test failures.
Currently the incremental parser is not producing trees with the correct text. However, this bug was introduced in the past and is failing now that debug assertions are checked in builds. See dotnet#47610
sharwell
force-pushed
the
disallow-fail
branch
from
a27666d
to
5045f94
Compare
|
@sharwell what is this waiting on? |
|
@333fred it still has a failing test (and possible crash), plus it needs ship room approval after it's passing |
sharwell
force-pushed
the
disallow-fail
branch
from
971c35d
to
81bc312
Compare
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FatalErrorhandlers in VS and OOPFail integration tests immediately on command execution failure