Fix problems caused by hidden sequence point when a switch expression is a closure scope #38182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion instruction in expression context Fixes dotnet#37237 Compiler emits incorrect EnC closure data to PDB for nested switch expressions Fixes dotnet#37232 Expression bodied method whose expression is a switch expression is missing debug info Fixes dotnet#37261
gafter
added
Area-Compilers
PR For Personal Review Only
|
@tmat When you're back from vacation I'd love to consult with you about the proper way to handle this. |
|
Sorry, I should have retargeted these PRs before removing that branch. Repushed branch and will reopen and retarget. |
…4-preview1-37237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trial approach to fixing problems caused by hidden sequence point when a switch expression is a closure scope. I've added a failing test to demonstrate that this approach is not quite correct.
Compiler shouldn't emit hidden sequence points on display class creation instruction in expression context
Fixes Compiler shouldn't emit hidden sequence points on display class creation instruction in expression context #37237
Compiler emits incorrect EnC closure data to PDB for nested switch expressions
Fixes Compiler emits incorrect EnC closure data to PDB for nested switch expressions #37232
Expression bodied method whose expression is a switch expression is missing debug info
Fixes Expression bodied method whose expression is a switch expression is missing debug info #37261