Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rude edits not detected when changing (primary) constructor initializer #68731

Closed
Tracked by #68477
tmat opened this issue Jun 22, 2023 · 0 comments · Fixed by #69193
Closed
Tracked by #68477

Rude edits not detected when changing (primary) constructor initializer #68731

tmat opened this issue Jun 22, 2023 · 0 comments · Fixed by #69193
Assignees
Milestone

Comments

@tmat
Copy link
Member

tmat commented Jun 22, 2023

See disabled tests.

class C { C() : base(stackalloc int[1]) {} C(Span<int> span) {} }
class C { C() : base(stackalloc int[2]) {} C(Span<int> span) {} }
class C { C(int x) : this(() => x) {} C(Func<int> f) {} }
class C { C(int x) : this(() => 1) {} C(Func<int> f) {} }

etc.

@tmat tmat self-assigned this Jun 22, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 22, 2023
@arkalyanms arkalyanms removed the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 3, 2023
tmat added a commit that referenced this issue Aug 8, 2023
* Enable tests for 68731

* Fix unsupported operation detection
@tmat tmat added this to the 17.8 P2 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants