Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline parameter hint is off when incorrect number of arguments is passed #59317

Closed
tmat opened this issue Feb 5, 2022 · 3 comments · Fixed by #76532 · May be fixed by #60184
Closed

Inline parameter hint is off when incorrect number of arguments is passed #59317

tmat opened this issue Feb 5, 2022 · 3 comments · Fixed by #76532 · May be fixed by #60184
Assignees
@akhera99
Labels
Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
Backlog

Comments

@tmat
Copy link
Member

tmat commented Feb 5, 2022

image
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 5, 2022
@tmat tmat removed the Area-IDE label Feb 5, 2022
@CyrusNajmabadi
Copy link
Member

is this incorrect? it seems somewhat reasonable? We could have the feature disable in the case of a non-exact match.

@tmat
Copy link
Member Author

tmat commented Feb 6, 2022 •
edited
Loading

Actually, the above is reasonable. Wrong example. When I saw this in real code the types and actually named arguments didn't match:

image

@CyrusNajmabadi
Copy link
Member

Ah yeah. at the very least, we should not add inline hints for parameters that already have a named-argument :)

@jinujoseph jinujoseph added Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 9, 2022
@jinujoseph jinujoseph added this to the 17.2 milestone Feb 9, 2022
@akhera99 akhera99 mentioned this issue Mar 15, 2022
Open
@jinujoseph jinujoseph modified the milestones: 17.2, 17.3 May 5, 2022
@arunchndr arunchndr modified the milestones: 17.3, 17.6 P2 Jan 17, 2023
@github-project-automation github-project-automation bot moved this to InQueue in Small Fixes Oct 22, 2024
@arunchndr arunchndr modified the milestones: 17.6 P2, Backlog Oct 29, 2024
@CyrusNajmabadi CyrusNajmabadi mentioned this issue Dec 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from InQueue to Completed in Small Fixes Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akhera99 akhera99

Labels
Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
Small Fixes
Status: Completed
Milestone
Backlog
5 participants
@tmat @CyrusNajmabadi @jinujoseph @akhera99 @arunchndr