Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function pointer calling convention keywords should be classified #48324

Closed
KyouyamaKazusa0805 opened this issue Oct 5, 2020 · 5 comments
Closed
Labels
Area-IDE Feature - Function Pointers Adding Function Pointers IDE-IntelliSense Completion, Signature Help, Quick Info
Milestone

Comments

@KyouyamaKazusa0805
Copy link

KyouyamaKazusa0805 commented Oct 5, 2020

Version Used:
VS 16.7.5

Steps to Reproduce:

Type code

delegate* managed<void> ptr

Expected Behavior:
All calling convention keywords (managed here) should be colorized.

Actual Behavior:
They are in default color.

@sharwell sharwell changed the title Function pointer calling conversion keywords should be colorized Function pointer calling convention keywords should be classified Oct 6, 2020
@sharwell sharwell added Area-IDE IDE-IntelliSense Completion, Signature Help, Quick Info Feature - Function Pointers Adding Function Pointers labels Oct 6, 2020
@sharwell sharwell added this to the Compiler.Next milestone Oct 6, 2020
@sharwell
Copy link
Member

sharwell commented Oct 6, 2020

@333fred please let @JoeRobich know what this is supposed to do and we can get it implemented for 16.9

@333fred
Copy link
Member

333fred commented Oct 6, 2020

I have no idea what this is supposed to do :). @jasonmalinowski, did you have a design in mind for classification of the managed/unmanaged tokens?

@jasonmalinowski
Copy link
Member

They're keywords. This works in 16.8; the bug report is against 16.7 and we likely hadn't gotten any of it working there.

@jasonmalinowski
Copy link
Member

@Sunnie-Shine: this should be working in the latest 16.8 Previews if you want to give those a shot. There's a bunch of other fixes there too you'll want as that's the first real version that has IDE support.

@KyouyamaKazusa0805
Copy link
Author

@jasonmalinowski Thank you! I'm sorry for this issue :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature - Function Pointers Adding Function Pointers IDE-IntelliSense Completion, Signature Help, Quick Info
Projects
None yet
Development

No branches or pull requests

4 participants