Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion for methods within a cref do not include enough info to disambiguate #43139

Closed
davkean opened this issue Apr 7, 2020 · 1 comment · Fixed by #67140
Closed

Completion for methods within a cref do not include enough info to disambiguate #43139

davkean opened this issue Apr 7, 2020 · 1 comment · Fixed by #67140
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone

Comments

@davkean
Copy link
Member

davkean commented Apr 7, 2020

Version Used:

Steps to Reproduce:

If I complete this method:

image:

        /// <remarks>
        /// Callers are responsible for calling <see cref="VsReferenceManagerUser.Dispose"/> on
        /// the returned instance when finished with it.
        /// </remarks>

I get this warning:

Error	CS0419	Ambiguous reference in cref attribute: 'VsReferenceManagerUser.Dispose'. Assuming 'VsReferenceManagerUser.Dispose()', but could have also matched other overloads including 'VsReferenceManagerUser.Dispose(bool)'.	Microsoft.VisualStudio.ProjectSystem.VS.Implementation	C:\CPS\src\Microsoft.VisualStudio.ProjectSystem.VS.Implementation\References\VsReferenceManagerUserFactory.cs	48	Active

The completion should automatically include the parentheses to disambiguate:

        /// <remarks>
        /// Callers are responsible for calling <see cref="VsReferenceManagerUser.Dispose()"/> on
        /// the returned instance when finished with it.
        /// </remarks>
@davkean davkean changed the title Completion for methods within a cref do not include Completion for methods within a cref do not include enough info to disambiguate Apr 7, 2020
@gafter gafter added the Area-IDE label Apr 7, 2020
@jinujoseph jinujoseph added this to the Backlog milestone Apr 8, 2020
@jinujoseph jinujoseph added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Apr 8, 2020
@sharwell
Copy link
Member

sharwell commented Apr 8, 2020

Related to dotnet/csharplang#320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants