CSharpVirtualCharService throwing various asserts

[jasonmalinowski]

Steps to Reproduce:

1. Create a new C# console project.
2. Type #line 1 "A\B"

Expected Behavior: No asserts

Actual Behavior: Asserts

[jasonmalinowski]

FYI to @CyrusNajmabadi been seeing a bunch of asserts here. Entirely unable to figure out a consistent repro though...

[jasonmalinowski]

Ah, worked out one scenario. Bug updated. 😄

[CyrusNajmabadi]

oh wacky. looking now!

[CyrusNajmabadi]

Hrmm. @jasonmalinowski @sharwell I'm having trouble debugging roslyn. I upgraded to 15.9p1 today. I have the latest roslyn, which i built fully. But when i try to debug i get this:

part "Microsoft.CodeAnalysis.Editor.TypeScript.Features.Classifier.SemanticClassificationTaggerProvider". ---> System.MissingMethodException: Method not found: 'Void Microsoft.CodeAnalysis.Editor.Tagging.AsynchronousViewTaggerProvider`1..ctor(Microsoft.CodeAnalysis.Shared.TestHooks.IAsynchronousOperationListener, Microsoft.CodeAnalysis.Editor.IForegroundNotificationService)'.
   at Microsoft.CodeAnalysis.Editor.TypeScript.Features.Classifier.AbstractAsyncClassificationTaggerProvider..ctor(TaskHandler taskHandler, IForegroundNotificationService notificationService, IAsynchronousOperationListenerProvider asyncListenerProvider, JoinableTaskContext joinableTaskContext)
   at Microsoft.CodeAnalysis.Editor.TypeScript.Features.Classifier.SemanticClassificationTaggerProvider..ctor(TaskHandler taskHandler, IForegroundNotificationService notificationService, ISemanticChangeNotificationService semanticChangeNotificationService, TypeScriptSemanticClassificationMap classificationMap, FileContentTypeService fileContentTypeService, IAsynchronousOperationListenerProvider asyncListenerProvider, JoinableTaskContext joinableTaskContext)

Note that that's typescript dying. Is it possible we changed AsynchronousViewTaggerProvider in a way that breaks them?

[CyrusNajmabadi]

I think this is caused by this PR: #28781

It added IThreadingContext to this type that is shared with TypeScript unfortunately :(

[jasonmalinowski]

Yes, @JieCarolHu is already addressing that with the TypeScript team as we speak. That issue should only be constrained to TypeScript scenarios though.

[CyrusNajmabadi]

Odd. I'm getting it even just opening a c# console app. That said, i'm removing TS/JS support from my VS since i don't really need it :)

[CyrusNajmabadi]

Ok. So i've now learned something new about C#. You can have strings inside a pp-directive. And those strings do not have escape chars in them... wow.

[CyrusNajmabadi]

Ah. I get why that is. These are intended to be filepaths. And it would have been really annoying to have to escape everything. Weird :)