Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to implementation (Ctrl+F12) is broken for interface async methods #28827

Closed
vsfeedback opened this issue Jul 25, 2018 · 9 comments · Fixed by #33227
Closed

Go to implementation (Ctrl+F12) is broken for interface async methods #28827

vsfeedback opened this issue Jul 25, 2018 · 9 comments · Fixed by #33227
Assignees
Labels
Area-IDE Bug Developer Community The issue was originally reported on https://developercommunity.visualstudio.com Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@vsfeedback
Copy link

I defined an interface with async methods in a .Net Standard 2.0 project. And two implementations in two .Net Core 2.1 projects.
When I press Ctrl+F12 over the interface name, the Visua Studio 'implementations' window displays the two implementations.
But when I press Ctrl+F12 over a method whose implementation has async keyword method, it doesn't find any implementation, presenting a dialog into saying "This symbol has no implementations".
The expected result is that the 'implementations' window should present the two implementations of the method.

This issue has been moved from https://developercommunity.visualstudio.com/content/problem/295266/go-to-implementation-ctrlf12-is-broken-for-interfa.html
VSTS ticketId: 649802

These are the original issue comments:
(no comments)
These are the original issue solutions:
(no solutions)

@jinujoseph jinujoseph added this to the 16.0 milestone Jul 25, 2018
@jinujoseph jinujoseph added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Jul 25, 2018
@paulovila
Copy link

Hi @jinujoseph is there any progress with this bug?

@jinujoseph
Copy link
Contributor

@paulovila not yet , it's in our list todo

@paulovila
Copy link

paulovila commented Nov 9, 2018

Hi @jinujoseph Any time this year?

@CyrusNajmabadi
Copy link
Member

@paulovila Would you be interested in contributing a fix here?

@paulovila
Copy link

paulovila commented Nov 9, 2018

Definitely, I'd be glad to help, my email is []

@CyrusNajmabadi
Copy link
Member

Great! I'd recommend starting with: https://github.com/dotnet/roslyn/wiki/Building-Testing-and-Debugging

When you've gotten to a buildable state, let me know. Thanks!

@paulovila
Copy link

I’ve have Roslyn compiled, where should I go next?.
Regards, Paulo

@CyrusNajmabadi
Copy link
Member

Hi @paulovila ! First, if you fully build and then hit f5 that should launch another instance of VS that you can debug from the VS you're in. Within that VS try to repro the scenario (i.e. ctrl-f12). This will tehn let you hit breakpoints you can set up in teh main VS. i recommend starting in GoToImplementationCommandHandler.ExecuteCommand. That's a good starting point to start debugging through to see at what point things start failing.

Let me know if htat's enough to go off of. Thanks!

@jinujoseph jinujoseph assigned ryzngard and unassigned sharwell Jan 18, 2019
@jinujoseph jinujoseph modified the milestones: 16.0, 16.0.P3 Jan 18, 2019
@ryzngard
Copy link
Contributor

The problem comes in because the types and namespaces are equivalent up through the global namespace, but the ContainingSymbol for each global namespace is different. One is NetModule System.Runtime.dll and one is NetModule netstandard.dll when calling AreEquivalentWorker.

@jinujoseph jinujoseph modified the milestones: 16.0.P3, 16.0.P4 Feb 4, 2019
@jinujoseph jinujoseph modified the milestones: 16.0.P4, 16.1.P1 Feb 11, 2019
@jinujoseph jinujoseph added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 3 - Working help wanted The issue is "up for grabs" - add a comment if you are interested in working on it labels Feb 21, 2019
@sharwell sharwell added the Developer Community The issue was originally reported on https://developercommunity.visualstudio.com label Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Developer Community The issue was originally reported on https://developercommunity.visualstudio.com Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants