Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Style: enforce named arguments for literals #19186

Closed
alrz opened this issue May 2, 2017 · 8 comments
Closed

Code Style: enforce named arguments for literals #19186

alrz opened this issue May 2, 2017 · 8 comments

Comments

@alrz
Copy link
Member

alrz commented May 2, 2017

Note: there is already a refactoring for adding named arguments.

@Pilchie Pilchie added this to the Unknown milestone May 3, 2017
@jcouv
Copy link
Member

jcouv commented May 28, 2017

📝 I expect we'll add support for non-trailing named arguments in 15.5. Then enforcing that literals be named will make more sense (be less annoying).

@jcouv
Copy link
Member

jcouv commented Sep 6, 2017

The non-trailing named arguments feature is merged to master, so this can go ahead.

@jcouv jcouv self-assigned this Sep 6, 2017
@jcouv jcouv modified the milestones: 15.5, Unknown Sep 6, 2017
@jcouv jcouv added the 4 - In Review A fix for the issue is submitted for review. label Sep 11, 2017
@dpoeschl
Copy link
Contributor

@jcouv What's the status of this one? I thought you had it almost working.

@jcouv
Copy link
Member

jcouv commented Sep 26, 2017

One issue remains in the PR (how the new codefix interacts with the existing refactoring). I should be able to merge by next week (in time for 15.5 preview 2).

@jcouv jcouv modified the milestones: 15.5, 15.later Oct 11, 2017
@jcouv jcouv added 3 - Working and removed 4 - In Review A fix for the issue is submitted for review. labels Oct 12, 2017
@jinujoseph jinujoseph modified the milestones: 15.6, Unknown Nov 3, 2017
@jcouv
Copy link
Member

jcouv commented Nov 23, 2017

Quick update: from discussions following the issue I mentioned above, that PR is snowballed. The existing refactoring would need to be removed and the code migrated into the new codefix.

@jcouv jcouv removed their assignment Jan 3, 2018
@jcouv jcouv removed the 3 - Working label Jan 3, 2018
@jcouv
Copy link
Member

jcouv commented Jan 3, 2018

I've dropped my PR with some rationale. If anyone is interested, feel free to pick up this issue.

@alrz
Copy link
Member Author

alrz commented Jan 4, 2018

running such a fixer on the Roslyn codebase was actually rather annoying (consider all the Assert methods, with literals for the expected values).

probably it's best to limit this to invocations with >2 arguments.

@CyrusNajmabadi
Copy link
Member

Unlikely to do this given lack of feedback.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@dotnet dotnet locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants