LSP Protocol: Fix some serialization errors

dotnet · Aug 15, 2024 · 70ede42 · 70ede42
1 parent c52c154
commit 70ede42
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/...ageServer/Protocol/Protocol/Internal/Efficiency/OptimizedVSCompletionListJsonConverter.cs b/...ageServer/Protocol/Protocol/Internal/Efficiency/OptimizedVSCompletionListJsonConverter.cs
@@ -57,14 +57,8 @@ public override void Write(Utf8JsonWriter writer, OptimizedVSCompletionList valu
             JsonSerializer.Serialize(writer, completionList.CommitCharacters, options);
         }
 
-        if (completionList.IsIncomplete)
-        {
-            writer.WriteBoolean("isIncomplete", completionList.IsIncomplete);
-        }
-        else
-        {
-            // Default is "false" so no need to serialize
-        }
+        // this is a required property per the LSP spec
+        writer.WriteBoolean("isIncomplete", completionList.IsIncomplete);
 
         writer.WritePropertyName("items");
         if (completionList.Items == null || completionList.Items.Length == 0)
@@ -153,11 +147,8 @@ private static void WriteCompletionItem(Utf8JsonWriter writer, CompletionItem co
             }
         }
 
-        var label = completionItem.Label;
-        if (label != null)
-        {
-            writer.WriteString("label", label);
-        }
+        // label is required per the LSP spec
+        writer.WriteString("label", completionItem.Label);
 
         if (completionItem.LabelDetails != null)
         {

diff --git a/src/LanguageServer/Protocol/Protocol/UnchangedDocumentDiagnosticReport.cs b/src/LanguageServer/Protocol/Protocol/UnchangedDocumentDiagnosticReport.cs
@@ -21,7 +21,6 @@ internal class UnchangedDocumentDiagnosticReport
     /// Gets the kind of this report.
     /// </summary>
     [JsonPropertyName("kind")]
-    [JsonRequired]
 #pragma warning disable CA1822 // Mark members as static
     public string Kind => DocumentDiagnosticReportKind.Unchanged;
 #pragma warning restore CA1822 // Mark members as static