Update Testing README to add best practice for caching ReferenceAssemblies #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 7, 2024
|
@sharwell, this PR has some documentation changes that are also related to #1162. Feel free to either take this PR as-is, or if you want the test framework stuff as part of your change I can rebase away that part and make this reference assembly specific. Edit: I rebased away the XUnit stuff since that's already merged. |
MattKotsenas
force-pushed
the
feature/testing-docs
branch
from
9a356ac
to
a5d64da
Compare
MattKotsenas
changed the title
|
Hi @MattKotsenas, Can you review #1176 to see if it meets your needs in a (hopefully) simpler fashion? Thanks! |
|
@MattKotsenas I believe this should no longer be necessary (per the previous comment). Please feel free to reopen if you find otherwise. |
|
Sorry, this fell down my TODO list. This works for me! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "best practice" and example of caching
ReferenceAssembliesbetween tests. New users of the testing infrastructure often set the reference assemblies in a constructor, but don't usestaticor another method to share the instance between tests resulting in a lot of re-resolution and slow tests. As best I can tell this guidance isn't documented anywhere, but all the tests seem to do it.