The Analyzer for CA1854: Prefer the IDictionary.TryGetValue Is Not Working Properly

[vsfeedback]

This issue has been moved from a ticket on Developer Community.

---

The analyzer for CA1854: Prefer the IDictionary.TryGetValue(TKey, out TValue) method is not working properly. For example it did not create a warning (as I have setup in my EditorConfig) for this code:

if (oldTopNames.ContainsKey(key) && !string. IsNullOrEmpty(kvDI.Value.OriginalTopLevelPlanName)) {
    kvDI.Value.OriginalTopLevelPlanName = oldTopNames[key];
}

It should have created a refactoring to change it to this code:

if (oldTopNames.TryGetValue(key, out var planName) && !string. IsNullOrEmpty(kvDI.Value.OriginalTopLevelPlanName)) {
    kvDI.Value.OriginalTopLevelPlanName = planName;
}

---

Original Comments

Feedback Bot on 4/5/2023, 07:38 PM:

(private comment, text removed)

---

Original Solutions

(no solutions)

[CollinAlpert]

Hi, I developed this analyzer. It currently only emits a diagnostic when ContainsKey is the only condition in the if block. I'll see if I can get around to fixing that sometime soon.

[CollinAlpert]

@mavasani Should be fixed by #6199.

[buyaa-n]

@mavasani Should be fixed by #6199.

Did you add a test for this in #6199? If not, could you add one to verify this fixed? Thanks!

[CollinAlpert]

I added an explicit test now.

[buyaa-n]

Thank you!