Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildTransitive to fix netcoreapp3 on windows vs not #864

Closed
clairernovotny opened this issue Jan 25, 2019 · 2 comments
Closed

Add buildTransitive to fix netcoreapp3 on windows vs not #864

clairernovotny opened this issue Jan 25, 2019 · 2 comments
Assignees

Comments

@clairernovotny
Copy link
Contributor

clairernovotny commented Jan 25, 2019

Due to the way netcoreapp3 works, after discussion with @terrajobst, we need to use the new buildTransitive folder with NuGet to supply two versions of the library for netcoreapp3: 1 with the overloads and one without.

https://github.com/NuGet/Home/wiki/Allow-package--authors-to-define-build-assets-transitive-behavior

We can switch them on a condition (UseWPF/UseWindowsForms/something else?) from a targets file for that TFM and be sure the targets will be applied across all consumers.

Plan:

  • Build netcoreapp3 twice, with and without
  • put a blank entry in \lib\netcoreapp3.0 (_._).
  • Use a targets file in buildTransitive\netcoreapp3.0 to include an ItemGroup with a Reference element. Will conditionally use the right version of the library based on the properties.
@clairernovotny clairernovotny self-assigned this Jan 25, 2019
@clairernovotny clairernovotny changed the title Add a System.Reactive.WindowsDesktop Add buildTransitive to fix netcoreapp3 on windows vs not Jan 25, 2019
@glennawatson
Copy link

Be interested to see how you you approach this, will likely emulate for ReactiveUI.

@clairernovotny
Copy link
Contributor Author

This is fixed in #859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants