Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Windows/x64: 15 Regressions on 7/28/2023 9:42:28 PM #20264

Closed
performanceautofiler bot opened this issue Aug 1, 2023 · 1 comment
Closed

[Perf] Windows/x64: 15 Regressions on 7/28/2023 9:42:28 PM #20264

performanceautofiler bot opened this issue Aug 1, 2023 · 1 comment
Labels
arch-x64 branch-refs/heads/main kind-micro os-windows perf-regression PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Aug 1, 2023 •
edited
Loading

Run Information

Name Value
Architecture x64
OS Windows 10.0.18362
Queue TigerWindows
Baseline 1da23b146496d95f017439a48f62e78ec15b0289
Compare 60c49c6156e20183e19b87dc7ba8e147674a9f85
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Reflection.Attributes

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
484.78 ns 547.40 ns 1.13 0.07 False 4054.644985747603 3946.824834749764 0.9734082388527637)
518.03 ns 584.43 ns 1.13 0.13 False
487.36 ns 537.63 ns 1.10 0.09 False
132.57 ns 144.93 ns 1.09 0.06 False 1336.144652348911 1369.7891939383028 1.0251803137708522)
85.63 ns 97.32 ns 1.14 0.10 False
502.25 ns 584.50 ns 1.16 0.11 False
514.30 ns 570.30 ns 1.11 0.11 False

graph
graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Reflection.Attributes*'

Payloads

Baseline
Compare

System.Reflection.Attributes.IsDefinedClassHitInherit

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 547.396072062384 > 515.1367416169664.
IsChangePoint: Marked as a change because one of 5/19/2023 12:51:11 AM, 6/9/2023 2:21:24 AM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -14.238461861397116 (T) = (0 -552.5501224232054) / Math.Sqrt((42.311369780344485 / (32)) + (136.63080647674127 / (8))) is less than -2.0243941639098457 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (32) + (8) - 2, .025) and -0.12427559468155766 = (491.4721310656138 - 552.5501224232054) / 491.4721310656138 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Reflection.Attributes.IsDefinedMethodOverrideHitInherit

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 584.4342851815348 > 541.3003390126819.
IsChangePoint: Marked as a change because one of 5/19/2023 4:22:12 AM, 6/9/2023 2:21:24 AM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -15.14607374323743 (T) = (0 -571.9866521164646) / Math.Sqrt((173.09239166203992 / (32)) + (62.52828619560778 / (8))) is less than -2.0243941639098457 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (32) + (8) - 2, .025) and -0.1065588079003461 = (516.9057875936913 - 571.9866521164646) / 516.9057875936913 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Reflection.Attributes.IsDefinedClassHit

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 537.634382183908 > 516.3459856865713.
IsChangePoint: Marked as a change because one of 5/19/2023 10:30:38 AM, 6/9/2023 2:21:24 AM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -5.423285431757207 (T) = (0 -555.6893169825724) / Math.Sqrt((246.4861913533616 / (32)) + (966.9342999631102 / (8))) is less than -2.0243941639098457 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (32) + (8) - 2, .025) and -0.12443215303222105 = (494.1955061353079 - 555.6893169825724) / 494.1955061353079 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Reflection.Attributes.GetCustomAttributesMethodBaseMissInherit

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 144.93475267097577 > 141.83907566767547.
IsChangePoint: Marked as a change because one of 4/29/2023 8:32:21 PM, 4/30/2023 11:12:57 PM, 5/19/2023 10:30:38 AM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -3.2797119221284623 (T) = (0 -146.44054781159866) / Math.Sqrt((164.400109674128 / (32)) + (7.048210943770012 / (8))) is less than -2.0243941639098457 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (32) + (8) - 2, .025) and -0.05813825280374134 = (138.39453154970647 - 146.44054781159866) / 138.39453154970647 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Reflection.Attributes.IsDefinedMethodBaseMiss

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 97.31797249599701 > 92.2200654960572.
IsChangePoint: Marked as a change because one of 5/16/2023 5:40:18 PM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -17.135602820896562 (T) = (0 -97.06734479941402) / Math.Sqrt((6.344236308427415 / (31)) + (1.4905005680183856 / (8))) is less than -2.026192463026769 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (31) + (8) - 2, .025) and -0.1240770488112194 = (86.35292829977153 - 97.06734479941402) / 86.35292829977153 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Reflection.Attributes.IsDefinedMethodOverrideHit

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 584.4963737906646 > 535.5898774089309.
IsChangePoint: Marked as a change because one of 5/19/2023 4:22:12 AM, 6/8/2023 8:20:44 PM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -19.02460572939025 (T) = (0 -571.8420049204844) / Math.Sqrt((138.69660472106565 / (31)) + (44.688875052741274 / (8))) is less than -2.026192463026769 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (31) + (8) - 2, .025) and -0.11797040902769217 = (511.50012585558505 - 571.8420049204844) / 511.50012585558505 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Reflection.Attributes.IsDefinedMethodOverrideMiss

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 570.3023710487589 > 540.6567853616666.
IsChangePoint: Marked as a change because one of 5/5/2023 7:39:36 PM, 5/18/2023 7:10:13 PM, 6/9/2023 2:21:24 AM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -10.496936364480925 (T) = (0 -579.8681718343632) / Math.Sqrt((168.77449497372612 / (30)) + (206.47784217380357 / (8))) is less than -2.028094000977961 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (30) + (8) - 2, .025) and -0.11295961626356815 = (521.0145663515615 - 579.8681718343632) / 521.0145663515615 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS Windows 10.0.18362
Queue TigerWindows
Baseline 1da23b146496d95f017439a48f62e78ec15b0289
Compare 60c49c6156e20183e19b87dc7ba8e147674a9f85
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Text.Perf_Ascii

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
21.69 ns 31.02 ns 1.43 0.10 False
12.36 ns 21.96 ns 1.78 0.12 False
3.68 ns 4.97 ns 1.35 0.28 False

graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Perf_Ascii*'

Payloads

Baseline
Compare

System.Text.Perf_Ascii.ToLowerInPlace_Chars(Size: 128)

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 31.020763797441944 > 22.676796970187272.
IsChangePoint: Marked as a change because one of 6/6/2023 4:05:41 PM, 6/9/2023 2:21:24 AM, 7/1/2023 6:36:20 PM, 7/4/2023 5:42:46 PM, 7/14/2023 2:26:40 PM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -125.25529285542711 (T) = (0 -30.9795352869659) / Math.Sqrt((0.12784485642465543 / (32)) + (0.01293432462478879 / (8))) is less than -2.0243941639098457 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (32) + (8) - 2, .025) and -0.4344835818033405 = (21.596298263672296 - 30.9795352869659) / 21.596298263672296 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Text.Perf_Ascii.ToUpperInPlace_Bytes(Size: 128)

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 21.9612850571681 > 12.989431898199008.
IsChangePoint: Marked as a change because one of 7/14/2023 2:26:40 PM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -21.196622259941268 (T) = (0 -22.839235270476788) / Math.Sqrt((6.21406730781386 / (32)) + (0.1362615178073915 / (8))) is less than -2.0243941639098457 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (32) + (8) - 2, .025) and -0.7437864951252185 = (13.097495211899057 - 22.839235270476788) / 13.097495211899057 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Text.Perf_Ascii.IsValid_Chars(Size: 128)

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 4.968718295815746 > 3.845019962954898.
IsChangePoint: Marked as a change because one of 5/19/2023 10:30:38 AM, 6/16/2023 8:27:26 PM, 6/29/2023 3:17:38 AM, 7/14/2023 2:26:40 PM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -11.190583147872713 (T) = (0 -5.069911238186387) / Math.Sqrt((0.12867304308611557 / (31)) + (0.07724726113517213 / (8))) is less than -2.026192463026769 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (31) + (8) - 2, .025) and -0.3501765899426291 = (3.7549986245886657 - 5.069911238186387) / 3.7549986245886657 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arch-x64 branch-refs/heads/main kind-micro os-windows perf-regression PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr untriaged labels Aug 1, 2023
@performanceautofiler
Copy link
Author

performanceautofiler bot commented Aug 1, 2023 •
edited
Loading

Run Information

Name Value
Architecture x64
OS Windows 10.0.18362
Queue TigerWindows
Baseline 1da23b146496d95f017439a48f62e78ec15b0289
Compare 60c49c6156e20183e19b87dc7ba8e147674a9f85
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
702.69 ns 780.03 ns 1.11 0.08 True
466.80 ns 522.49 ns 1.12 0.20 True
726.56 ns 850.09 ns 1.17 0.02 True

graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark*'

Payloads

Baseline
Compare

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance_4

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 780.0332318418178 > 739.6117316189473.
IsChangePoint: Marked as a change because one of 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -12.023820877715082 (T) = (0 -784.5426666293899) / Math.Sqrt((117.7158731958597 / (28)) + (340.3662446779185 / (8))) is less than -2.0322445093148245 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (28) + (8) - 2, .025) and -0.11705528573718034 = (702.3310991377166 - 784.5426666293899) / 702.3310991377166 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance_1

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 522.4880497939328 > 493.1333227720124.
IsChangePoint: Marked as a change because one of 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -6.8743812945222365 (T) = (0 -520.3393135351961) / Math.Sqrt((106.28455040517055 / (30)) + (394.9088128990819 / (8))) is less than -2.028094000977961 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (30) + (8) - 2, .025) and -0.10631105203281505 = (470.3372641709467 - 520.3393135351961) / 470.3372641709467 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance_5

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 850.0900275751968 > 773.6143223516577.
IsChangePoint: Marked as a change because one of 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -12.695926729998549 (T) = (0 -818.0859028014856) / Math.Sqrt((97.94038475362903 / (32)) + (325.7665858181517 / (8))) is less than -2.0243941639098457 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (32) + (8) - 2, .025) and -0.1144369054578144 = (734.0800531595938 - 818.0859028014856) / 734.0800531595938 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS Windows 10.0.18362
Queue TigerWindows
Baseline 1da23b146496d95f017439a48f62e78ec15b0289
Compare 60c49c6156e20183e19b87dc7ba8e147674a9f85
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Text.Encodings.Web.Tests.Perf_Encoders

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
57.14 ns 60.84 ns 1.06 0.13 False
110.92 ns 119.35 ns 1.08 0.09 False

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Encodings.Web.Tests.Perf_Encoders*'

Payloads

Baseline
Compare

System.Text.Encodings.Web.Tests.Perf_Encoders.EncodeUtf8(arguments: UnsafeRelaxed,no <escaping /> required,512)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 60.83536246070364 > 59.975706115249075.
IsChangePoint: Marked as a change because one of 4/28/2023 10:02:43 PM, 5/3/2023 7:05:50 AM, 7/14/2023 2:26:40 PM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -13.728625999302924 (T) = (0 -61.46233195025044) / Math.Sqrt((2.219313506322512 / (32)) + (0.1705375471385284 / (8))) is less than -2.0243941639098457 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (32) + (8) - 2, .025) and -0.07210919407532347 = (57.32842539724761 - 61.46233195025044) / 57.32842539724761 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Text.Encodings.Web.Tests.Perf_Encoders.EncodeUtf16(arguments: JavaScript,&Hello+<World>!,512)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 119.34763382853986 > 116.95071209145937.
IsChangePoint: Marked as a change because one of 4/28/2023 10:42:00 AM, 5/3/2023 1:06:54 PM, 7/4/2023 1:18:39 PM, 7/14/2023 2:26:40 PM, 7/28/2023 3:39:20 PM, 7/31/2023 7:57:50 PM falls between 7/23/2023 4:13:29 AM and 7/31/2023 7:57:50 PM.
IsRegressionStdDev: Marked as regression because -8.720075629272378 (T) = (0 -120.64180312561673) / Math.Sqrt((6.837841421397096 / (34)) + (4.943903493721315 / (8))) is less than -2.0210753903043583 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (34) + (8) - 2, .025) and -0.06999601215046722 = (112.74976892965428 - 120.64180312561673) / 112.74976892965428 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@cincuranet cincuranet mentioned this issue Aug 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-x64 branch-refs/heads/main kind-micro os-windows perf-regression PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cincuranet