From 29bf4f0e200514104463f96e865073a26174497a Mon Sep 17 00:00:00 2001 From: Rainer Sigwald Date: Thu, 9 Nov 2023 20:34:26 +0000 Subject: [PATCH] Log allowed environment vars case-insensitively I was recently investigating a problem where the issue was that `MSBuildSdksPath` was set incorrectly, so an SDK was being resolved incorrectly. I had initially ruled that out, because I knew that we should be logging environment variables that start with `MSBUILD`. We were, but case-sensitively. Since the canonical case for some of our config environment variables is not all caps, we should change that. --- src/Shared/EnvironmentUtilities.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Shared/EnvironmentUtilities.cs b/src/Shared/EnvironmentUtilities.cs index 71e7b576389..3b275ef40b5 100644 --- a/src/Shared/EnvironmentUtilities.cs +++ b/src/Shared/EnvironmentUtilities.cs @@ -15,9 +15,9 @@ internal static partial class EnvironmentUtilities public static bool IsWellKnownEnvironmentDerivedProperty(string propertyName) { - return propertyName.StartsWith("MSBUILD") || - propertyName.StartsWith("COMPLUS_") || - propertyName.StartsWith("DOTNET_"); + return propertyName.StartsWith("MSBUILD", StringComparison.OrdinalIgnoreCase) || + propertyName.StartsWith("COMPLUS_", StringComparison.OrdinalIgnoreCase) || + propertyName.StartsWith("DOTNET_", StringComparison.OrdinalIgnoreCase); } } }