Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsBuildSkipEagerWildCardEvaluationRegexes not respected #9736

Closed
rainersigwald opened this issue Feb 13, 2024 · 1 comment · Fixed by #9744
Closed

MsBuildSkipEagerWildCardEvaluationRegexes not respected #9736

rainersigwald opened this issue Feb 13, 2024 · 1 comment · Fixed by #9744
Assignees
Labels
bug Partner request Performance-Scenario-General This issue affects performance in general. Priority:1 Work that is critical for the release, but we could probably ship without regression triaged
Milestone

Comments

@rainersigwald
Copy link
Member

NuGet (and some other systems) set MSBuildSkipEagerWildCardEvaluationRegexes = [*?]+.*(?<!proj)$ to avoid spending time expanding globs for an evaluation that won't use them (for example, in NuGet static graph restore the evaluations don't need to expand Compile or Content globs since all NuGet cares about is package and project references).

This appears to be broken in 17.10.0-preview-24101-01+07fd5d51f:

dotnet new blazor
$env:MSBUILDDISABLEFEATURESFROMVERSION="17.10"
dotnet restore -bl -p:RestoreUseStaticGraphEvaluation=true
# cancel out of debugger
# inspect nuget.binlog

This shows concrete items for Content and Compile that were pulled in via glob.

@rainersigwald rainersigwald added bug regression Performance-Scenario-General This issue affects performance in general. labels Feb 13, 2024
@rainersigwald rainersigwald added this to the VS 17.10 milestone Feb 13, 2024
@rainersigwald rainersigwald added Partner request Priority:1 Work that is critical for the release, but we could probably ship without labels Feb 13, 2024
@jeffkl
Copy link
Contributor

jeffkl commented Feb 13, 2024

😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Partner request Performance-Scenario-General This issue affects performance in general. Priority:1 Work that is critical for the release, but we could probably ship without regression triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants