Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binlog message in case of failure to add embedded file(s) #9450

Closed
JanKrivanek opened this issue Nov 23, 2023 · 0 comments · Fixed by #10212
Closed

Add binlog message in case of failure to add embedded file(s) #9450

JanKrivanek opened this issue Nov 23, 2023 · 0 comments · Fixed by #10212
Assignees
@JanProvaznik
Labels
Area: Logging Good First Issue Self-contained issues good for first-time contributors. Iteration:2023December Priority:2 Work that is important, but not critical for the release size:2 triaged

Comments

@JanKrivanek
Copy link
Member

Context

#9307 (comment)
Failure to add file is silently skipped. A low-importance binlog message might be a helpful indicator here.

Suggested fix

Pass a delegate to ProjectImportsCollector for communicating error back to caller. In the BinaryLogger this should be mount to appending a log message. (Similar to how ProcessResult is handled).
This way an exception an file path could be logged for errorneous cases
@JanKrivanek JanKrivanek added Good First Issue Self-contained issues good for first-time contributors. Area: Logging needs-triage Have yet to determine what bucket this goes in. labels Nov 23, 2023
@JanKrivanek JanKrivanek mentioned this issue Nov 23, 2023
Merged
@AR-May AR-May added Priority:2 Work that is important, but not critical for the release Iteration:2023December and removed needs-triage Have yet to determine what bucket this goes in. labels Nov 28, 2023
@MichalPavlik MichalPavlik self-assigned this Nov 30, 2023
@MichalPavlik MichalPavlik removed their assignment Jan 4, 2024
@rokonec rokonec assigned rokonec and surayya-MS and unassigned rokonec Feb 8, 2024
@JanProvaznik JanProvaznik self-assigned this Jun 4, 2024
@JanProvaznik JanProvaznik mentioned this issue Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanProvaznik JanProvaznik

Labels
Area: Logging Good First Issue Self-contained issues good for first-time contributors. Iteration:2023December Priority:2 Work that is important, but not critical for the release size:2 triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add binlog message in case of failure to add embedded file JanProvaznik/msbuild
7 participants
@JanKrivanek @MichalPavlik @rokonec @JanProvaznik @JaynieBai @AR-May @surayya-MS