Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable xUnit2029 rule #10599

Closed
Tracked by #10557
f-alizada opened this issue Sep 3, 2024 · 0 comments · Fixed by #10600
Closed
Tracked by #10557

Enable/disable xUnit2029 rule #10599

f-alizada opened this issue Sep 3, 2024 · 0 comments · Fixed by #10600
Assignees

Comments

@f-alizada
Copy link
Contributor

f-alizada commented Sep 3, 2024

Context

After the #10577 is merged the new warnings of xunit analyzers were disabled. The goal is to check each warning and enable or leave as it is with explanation

https://xunit.net/xunit.analyzers/rules/xUnit2029

Goal

The goal is to enable the warning when Assert,Empty is used on the filtered collection.
Instead there is Assert.DoesNotContain(array, condition) could be used.

The pros of using this:

  • More readble test's code
  • Unified style in tests
This was referenced Sep 3, 2024
@f-alizada f-alizada self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant