Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression/8.0.3] Shell.NavBarIsVisible is not working on iOS #18948

Closed
ka4ep opened this issue Nov 22, 2023 · 12 comments · Fixed by #20173
Closed

[regression/8.0.3] Shell.NavBarIsVisible is not working on iOS #18948

ka4ep opened this issue Nov 22, 2023 · 12 comments · Fixed by #20173
Assignees
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-8.0.90 fixed-in-9.0.0-rc.1.24453.9 i/regression This issue described a confirmed regression on a currently supported version platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@ka4ep
Copy link

ka4ep commented Nov 22, 2023

Description

I have a shell page with defined Shell.NavBarIsVisible="false". When I was using .NET 7.0.101, the bar with the 'hamburger' button is hidden on both Android and iOS.
After upgrading from MAUI 7.0.101 to 8.0.3, the bar is still visible on iOS. It's hidden on Android as expected.

Steps to Reproduce

  1. Create a new MAUI app from template and choose framework .NET7 or .NET8.
  2. In the AppShell.xaml tag add lines:
    Shell.FlyoutBehavior="Flyout"
    Shell.NavBarIsVisible="False"
  3. Compile and run on Android/iOS device or simulator.
  4. On iOS .NET 8, the navigation bar is visible, even when stated otherwise.

Link to public reproduction project repository

https://github.com/ka4ep/Maui.NavBar.Repro

Version with bug

8.0.3

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

7.0.101

Affected platforms

iOS

Affected platform versions

iOS 15-17

Did you find any workaround?

No response

Relevant log output

Relevant .log files are in GitHub repository.
@ka4ep ka4ep added the t/bug Something isn't working label Nov 22, 2023
@jsuarezruiz jsuarezruiz added platform/iOS 🍎 area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Nov 22, 2023
@PureWeen PureWeen added the potential-regression This issue described a possible regression on a currently supported version., verification pending label Nov 22, 2023
@PureWeen PureWeen added this to the .NET 8 SR3 milestone Nov 22, 2023
@samhouts samhouts changed the title Shell.NavBarIsVisible is not working on iOS [regression/8.0.3] Shell.NavBarIsVisible is not working on iOS Dec 7, 2023
@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Dec 26, 2023
@XamlTest
Copy link

Verified this on Visual Studio Enterprise 17.9.0 Preview 2(8.0.3). Repro on iOS 17.0, MacCatalyst and Windows 11, not repro on Android 14.0-API34 with below Project:
NavBar8.zip

@jbfranklin
Copy link

So I assume this is getting fixed?

@PureWeen PureWeen modified the milestones: .NET 8 SR3, Backlog Jan 10, 2024
@ghost
Copy link

ghost commented Jan 10, 2024

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

@jsuarezruiz jsuarezruiz self-assigned this Jan 25, 2024
@jsuarezruiz jsuarezruiz added i/regression This issue described a confirmed regression on a currently supported version and removed potential-regression This issue described a possible regression on a currently supported version., verification pending labels Jan 25, 2024
@KevinJalais
Copy link

KevinJalais commented Feb 2, 2024

Hello,
I see that @jsuarezruiz created a pull request that fix the issue.
When this will be release?

I am working on a migration from Xamarin to MAUI and my customer is waiting for this bug fix to release the app on the stores.
Having this ugly navigation bar displayed with no possibility to hide it is a strong impediment.
By the way, I have the bug on both Android and iOS.

Please, send some update that I can communicate to my customer.

Many thanks.

@johannes-steurer
Copy link

Any update on when this is planned to be fixed?
It's still there on version 8.0.6 and I cannot see a fix for 8.0.7.
It's a blocking point for us!
Any workaround you can suggest?

@KevinJalais
Copy link

@johannes-steurer, on my side, the problem has been resolved with version 8.0.7.
If you use a NavigationPage you can set NavigationPage.SetHasNavigationBar(this, false); in your code behind (.xaml.cs file).

I acknowledge that it has not been resolved for Shell component, but as long as I use NavigationPage it's temporary satisfying.

@johannes-steurer
Copy link

@KevinJalais thanks for the quick feedback. as I use Shell the workaround does not work for me.

@JakodeWet
Copy link

Has there been any update on this? I see the PR is still open.
This is a blocker for us as we use Shell navigation and the workaround doesn't work for us.

@dbSoft-SoftwareSolutions

We have the same issue

@JakodeWet
Copy link

JakodeWet commented Mar 5, 2024

Ok, so we found a workaround. You can add the Shell.NavBarIsVisible=False property to your actual page and not the Shell itself. If you have a ContentBasePage, adding it there also works.
Currently we have it on our ContentBasePage and not in the Shell itself and its working.

@medarke
Copy link

medarke commented Jun 4, 2024

The suggestion that @JakodeWet made worked for me. It seems like a very fundamental thing that should have been fixed by now

@msrockswell
Copy link

You can write a handler for iOS to solve this problem.

MauiProgram.cs
image

Platforms/iOS/AppShell.cs
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-8.0.90 fixed-in-9.0.0-rc.1.24453.9 i/regression This issue described a confirmed regression on a currently supported version platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.