Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested CollectionViews aren't rendered correctly in iOS and MacCatalyst #16966

Closed
dmanning23 opened this issue Aug 23, 2023 · 7 comments
Closed
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/try-latest-version Please try to reproduce the potential issue on the latest public version t/bug Something isn't working

Comments

@dmanning23
Copy link

dmanning23 commented Aug 23, 2023

Description

When CollectionViews are nested to build complex controls, the resulting lists are not rendered correctly on iOS and Mac Catalyst. (see screenshots)
The height of each item appears to expand to fill the maximum height allowed.

The results are as expected on Android. (see screenshot)

Expected results:

Android:

Screenshot_1692826959

Actual Results:

iOS:

Simulator Screenshot - iPhone 14 Pro Max - 2023-08-23 at 16 43 03

MacCatalyst:

Screenshot 2023-08-23 at 4 43 30 PM

Steps to Reproduce

This is a somewhat complicated bug to reproduce, so I've repurposed the CollectionViewDemos from the maui-samples repository to show the bug.

  1. Create a model with a list of data
  2. Create a viewmodel with a list of the models
  3. Create a CollectionView that is databound to the viewmodel's list
  4. Add a nested CollectionView that is databound to the model's data

Link to public reproduction project repository

https://github.com/dmanning23/CollectionViewBugExample

Version with bug

7.0.92

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

iOS, macOS

Affected platform versions

iOS 16.4, MacCatalyst

Did you find any workaround?

I have not found a workaround for this issue.

Relevant log output

No response

@dmanning23 dmanning23 added the t/bug Something isn't working label Aug 23, 2023
@Unflab
Copy link

Unflab commented Aug 23, 2023

Could possibly be same issue as #9135.

@drasticactions
Copy link
Contributor

Could possibly be same issue as #9135.

There's a backport for that issue #15652. It's merged, but not in a shipping product yet. It should be in the newest net8.0 preview right now though. You can try it there and see if it's working there. If it is, then it should work in net7.0 whenever the service release ships.

@Eilon Eilon added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Aug 24, 2023
@rmarinho
Copy link
Member

Can you try on net8 to see if it works?

@rmarinho rmarinho added the s/try-latest-version Please try to reproduce the potential issue on the latest public version label Aug 25, 2023
@ghost
Copy link

ghost commented Aug 25, 2023

Hi @dmanning23. We have added the "s/try-latest-version" label to this issue, which indicates that we'd like you to try and reproduce this issue on the latest available public version. This can happen because we think that this issue was fixed in a version that has just been released, or the information provided by you indicates that you might be working with an older version.

You can install the latest version by installing the latest Visual Studio (Preview) with the .NET MAUI workload installed. If the issue still persists, please let us know with any additional details and ideally a reproduction project provided through a GitHub repository.

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@dmanning23
Copy link
Author

Can you try on net8 to see if it works?

I've installed Visual Studio Preview and the latest .Net 8 Preview, yet when I try to run the project under .Net8 I run into a bunch of error messages and general Visual Studio weirdness. It should be as simple as going to the project properties -> Target Platforms, and changing the Target .Net Runtime to .Net 8.0?

@ghost ghost removed the s/try-latest-version Please try to reproduce the potential issue on the latest public version label Aug 25, 2023
@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed s/try-latest-version Please try to reproduce the potential issue on the latest public version and removed s/verified Verified / Reproducible Issue ready for Engineering Triage labels Aug 31, 2023
@ghost
Copy link

ghost commented Aug 31, 2023

Hi @dmanning23. We have added the "s/try-latest-version" label to this issue, which indicates that we'd like you to try and reproduce this issue on the latest available public version. This can happen because we think that this issue was fixed in a version that has just been released, or the information provided by you indicates that you might be working with an older version.

You can install the latest version by installing the latest Visual Studio (Preview) with the .NET MAUI workload installed. If the issue still persists, please let us know with any additional details and ideally a reproduction project provided through a GitHub repository.

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@XamlTest
Copy link

Verified this on Visual Studio Enterprise 17.8.0 Preview 1.0. Repro on iOS 16.4 .NET 7, but not repro on iOS .NET 8, and not repro on Windows 11 and Android 13.0-API33 with below Project:
CollectionViewDemos.zip

image

@ghost ghost closed this as completed Sep 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/try-latest-version Please try to reproduce the potential issue on the latest public version t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants