Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefreshView TapGestureRecognizer Event does not respond on iOs for items which are only visible after scrolling #14060

Closed
Yannikk1996 opened this issue Mar 20, 2023 · 14 comments
Labels
area-gestures Gesture types platform/iOS 🍎 s/needs-attention Issue has more information and needs another look s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working

Comments

@Yannikk1996
Copy link

Yannikk1996 commented Mar 20, 2023

Description

In a RefreshView the TapGestureRecognizer Event does not respond on iOs for items which are only visible after scrolling. The TapGestureRecognizer Event works for the first items which can be displayed on the screen but for the items which can only be reached by scrolling down the TapGestureRecognizer Event will not be triggered. This happens when items created in xaml and also when added in c# code.

This also happens when using Scrollview. For Scrollview this only happens when adding items after its creation. Therefore recreating the complete scrollview control is a possible workaround.

This issue occurs on iOS. Windows and Android work as expected.

Steps to Reproduce

Link to public reproduction project repository

[-](https://github.com/Yannikk1996/RefreshViewNotWorking)

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

iOS 16.3.1

Did you find any workaround?

No

Relevant log output

No response

@Yannikk1996 Yannikk1996 added the t/bug Something isn't working label Mar 20, 2023
@jsuarezruiz jsuarezruiz added area-gestures Gesture types platform/iOS 🍎 s/needs-repro Attach a solution or code which reproduces the issue labels Mar 20, 2023
@ghost
Copy link

ghost commented Mar 20, 2023

Hi @Yannikk1996. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@Yannikk1996
Copy link
Author

Hey,

I created a minimal sample project and the GitHub repo is linked.

Best regards

@ghost ghost added s/needs-attention Issue has more information and needs another look and removed s/needs-repro Attach a solution or code which reproduces the issue labels Mar 22, 2023
@JonnySKK
Copy link

We are also encountering the exact same issue - on iOS only, and only for items which are only visible after scrolling - the click events do not work. Currently it's holding up being able to use the RefreshView at all on an important screen

@Yannikk1996
Copy link
Author

#14795 maybe similiar issue

@Yannikk1996 Yannikk1996 reopened this Apr 29, 2023
@Yannikk1996
Copy link
Author

Ipad is not affected.

@xXComanderXx
Copy link

Hey,
I have the exact same issue and didn't find a workaround. This makes it almost useless to use the RefreshView.

@cat0363
Copy link
Contributor

cat0363 commented May 10, 2023

Gestures now work when the device orientation is rotated causing the entire screen to redraw.
If you can do the same, you may be able to avoid this. But what should we do?

@Yannikk1996
Copy link
Author

Hi , I found the workaround from #14624 can work by using an additional Grid between Refresh and scrollview.

@cat0363
Copy link
Contributor

cat0363 commented May 10, 2023

It worked with the code below.
The name of the control is the one in the source code you uploaded.

stack.SizeChanged += (object sender, EventArgs e) =>
{
    Refresh.ForceLayout();
};

@Yannikk1996
Copy link
Author

@cat0363 thanks!

@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jun 19, 2023
@Zhanglirong-Winnie
Copy link

Verified this issue with Visual Studio Enterprise 17.7.0 Preview 1.0. Can repro on iOS platform with sample project.
https://github.com/Yannikk1996/RefreshViewNotWorking

@muak
Copy link

muak commented Jul 25, 2023

@cat0363
This workaround works fine. Thanks!

@hartez
Copy link
Contributor

hartez commented Jul 26, 2023

Possible this is fixed by #16385.

@jsuarezruiz
Copy link
Contributor

Fixed by #16385

@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-gestures Gesture types platform/iOS 🍎 s/needs-attention Issue has more information and needs another look s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants