Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce code analyzer #553

Closed
TomFinley opened this issue Jul 18, 2018 · 1 comment
Closed

Introduce code analyzer #553

TomFinley opened this issue Jul 18, 2018 · 1 comment
Assignees
Labels
API Issues pertaining the friendly API
Milestone

Comments

@TomFinley
Copy link
Contributor

Like most sufficiently large codebases the ML.NET project is guilty of having acquired a set of idioms. Internally we had a code analyzer, to help catch some of the most common issues that tended to come up in PRs, but sometimes we don't do this, and need to fix issues later (e.g., #271, #442, #478). I want to migrate that analyzer to the open source repository, to hopefully automate some of this.

There are of course other things we could do with an analyzer, once we have one.

/cc @ericstj

@TomFinley TomFinley added the API Issues pertaining the friendly API label Jul 18, 2018
@TomFinley TomFinley self-assigned this Jul 18, 2018
@TomFinley
Copy link
Contributor Author

It seems like there might be two styles of analyzers. There are analyzers for maintaining internal code consistency, quality, and style (as seen in #557, this necessarily could not possibly depend on ML.NET), as well as analyzers made to facilitate a user using ML.NET, to make certain tasks easier, or to warn when then API is potentially being misused.

@shauheen shauheen added this to the 0718 milestone Jul 19, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

No branches or pull requests

2 participants