-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a README.md to test/BaselineOutput
#100
Comments
We should also consider moving the folder under /tests to make the purpose more obvious. |
Does anyone remember why it's called ZBaselines instead of just baselines or TestBaselines? |
Because it would be sorted last in the folder view, so it's easy to find. :) |
Agreed w / @glebuk & @Ivanidzo4ka (move+rename). Placing under /test/baselineOutput/ may be easier to understand its purpose. |
So if we call it Baselines inside test folder, it would be first, and it would be easy to find as well! |
What do we think the best name for it is? Terse + understandable is my metric to optimize. Also, welcome @costin-eseanu! |
@justinormont I like your The intention of that directory is that it mirrors the This however brings up what might be a larger (different?) issue. The test outputs used to be written just to the root directory, alongside Right now, as near as I can tell, the test output is not being written to a single directory, which makes tracking changes to baselines harder to find, and makes the practice of using diff tools to see all the test divergences at a glance now impossible (I have, for example, one I'm not sure why it was changed to this new system exactly, but we should revisit, maybe instead writing them to Also hi @costin-eseanu , you seem familiar somehow. :D |
test/BaselineOutput
DRI RESPONSE: yes, we probably should. Basically this is folder where we keep baseline files for our tests. |
We should have a
README.md
to thetest/BaselineOutput
folder to explain its purpose.(Updated on 2018-07-02 to reflect the new location of the folder)
The text was updated successfully, but these errors were encountered: