Moved fsharpqa/Libraries/Core/NativeInterop/stackalloc test cases to NUnit #9521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Jun 22, 2020
I guess we can move this case fro our "component" tests, like we have new compiler tests now, which are spawning a separate process. |
cartermp
approved these changes
Jun 22, 2020
KevinRansom
approved these changes
Jun 22, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…NUnit (dotnet#9521) * Migrated zerosize01.fs test case * Migrated ofint6401.fs test case * Migrated ofint01.fs test case * Cleanup asserts * Migrated ofDateTime01.fs test case * Migrated constraint01.fs test case * Migrated E_constraint02.fs test case * Migrated E_constraint03.fs test case * Migrated ofenum01.fs test case * Reordered tests * Removed obsolete directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #7075.
Small note, there is one test case left in that folder which I was not able to move to NUnit: it is essentially testing that
stackalloc<T> -1throws aStackOverflowException. Of course, that exception will then crash the test-runner...Any idea on how to circumvent this issue? We could spin up a separate process to run the code snippet, but I'm not entirely sure it's worth the effort... (cc @vzarytovskii).