Moved fsharpqa/Libraries/Core/LanguagePrimitives test cases to NUnit

[ThorstenReichert]

Contributes to #7075.

Quick question on the side, I've found some .fsx test cases in fsharpqa/Libraries/Core/LanguagePrimitives, any pointers on how to run those and validate their output in NUnit tests?

[KevinRansom]

@ThorstenReichert

CompilerAssert.RunScriptWithOptions

Here are a couple of examples:

fsharp/tests/fsharp/Compiler/Language/SlicingQuotationTests.fs

Line 38 in aaeb058

[<Test>]

fsharp/tests/fsharp/Compiler/Language/SlicingQuotationTests.fs

Line 66 in aaeb058

[<Test>]

I hope this helps.

Kevin

    [<Test>]
    let ``Reverse slicing quotation on array2d with fixed index return expected expression``() =
        CompilerAssert.RunScriptWithOptions [| "--langversion:preview" |]
            """
open System
open System.Text.RegularExpressions
open FSharp.Quotations
open FSharp.Quotations.DerivedPatterns
open FSharp.Quotations.ExprShape
open FSharp.Quotations.Patterns
let test() = 
    let xs = array2D [ [1;2;3]; ]
    let q = <@ xs.[0..^1, ^1] @>
    
    let expectEqualWithoutWhitespace s1 s2 = 
        let a = Regex.Replace(s1, "\s", "") 
        let b = Regex.Replace(s2, "\s", "")
        if a <> b then failwithf "Expected '%s', but got\n'%s'" a b
        ()
    
    let expected = "Call (None, GetArraySlice2DFixed2, [ValueWithName ([[1; 2; 3]], xs), NewUnionCase (Some, Value (0)), NewUnionCase (Some, Call(None, [,]`1.GetReverseIndex,[ValueWithName([[1;2;3]], xs), Value(0), Value(1)])), Call(None, [,]`1.GetReverseIndex,[ValueWithName([[1;2;3]], xs), Value(1), Value(1)])])"
    expectEqualWithoutWhitespace expected (q.ToString())
    
test()
            """
            []

[KevinRansom]

@ThorstenReichert ,
BTW, @vzarytovskii is working on reorganizing and improving our TestFramework, so any feedback you have would be supper welcome right now.

Thanks again

Kevin

[KevinRansom]

Thank you.

[cartermp]

Thanks!

[ThorstenReichert]

@KevinRansom, thank you for the detailed example! Will try it out these days.

As for feedback for the testing framework (cc @vzarytovskii), I've found it relatively easy to get started. Most thoughts I have are probably in large parts due to a lack of familiarity with the codebase (in fact, I've only worked in FSharpSuite.Tests so far):

• The overall focus of what is being tested seems a bit fuzzy: I've seen tests for compiler warnings, IL code, some sporadic library modules, etc... Also, none of these areas seems to be tested exhaustively there, most of the tests I've seen are few and often for very specific scenarios (many of them seem to be regression tests). Compare this to e.g. the dotnet/runtime libraries tests, there it's a clear one production .dll / one test .dll responsible for testing that entire .dll.
• Some conventions around how to name tests / test modules, in what namespace to put them, or similar organisational "metadata" could be helpful to give the tests a coherent look-n-feel.