Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved CodeGen/EmittedIL/TailCalls over to NUnit #7386

Merged
merged 4 commits into from
Oct 31, 2019

Conversation

sergey-tihon
Copy link
Contributor

part of #7075

The only strange thing is that IL for

let run() = let x = 0 in foo(x,5)

omit name of local variable x ...
in bsl it was

    .locals init ([0] int32 x)

for me it looks like

    .locals init (int32 V_0)

full difference from bsl IL is in the commit 1703306

@sergey-tihon
Copy link
Contributor Author

@KevinRansom can you please suggest why local variable name can be omitted after ILdasm?

@cartermp
Copy link
Contributor

@KevinRansom any thoughts?

@KevinRansom
Copy link
Member

Oh the il differences are because of optimization. The change is from building debug to building release. I believe I fixed this with this PR:

@KevinRansom KevinRansom closed this Sep 1, 2019
@KevinRansom KevinRansom reopened this Sep 1, 2019
@sergey-tihon
Copy link
Contributor Author

sergey-tihon commented Sep 13, 2019

@KevinRansom can you please share the link to the PR that you mentioned?

Upd:

If I got it right The change is from building debug to building release.
means to remove -g from options

CompilerAssert.CompileLibraryAndVerifyILWithOptions [|"-g"; "--optimize-"; "--tailcalls+"|]

but for me it does not affect V_0 name

@KevinRansom
Copy link
Member

Thanks for this.

@KevinRansom KevinRansom merged commit fa6e7cc into dotnet:master Oct 31, 2019
@sergey-tihon sergey-tihon deleted the codegen_tailcalls branch October 31, 2019 04:34
@sergey-tihon
Copy link
Contributor Author

Thank you for merging this!
@KevinRansom can you please post here the link to PR you mentioned?

I believe I fixed this with this PR:

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* TailCalls test migration

* fix the diff in IL

* fix for netcore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants