Better record and value formatting in tools

[cartermp]

Fixes #7019, #7163

Example code:

open System

type R =
    { MyInt: int
      MyString: string
      MyDateTime: DateTime }

type R' = { I: int }

type AR = {| MyInt: int; MyString: string; MyDateTime: DateTime |}

let ar = {| I = 12; Name = "phillip" |}

Records

Multiple labels:

Single label:

Anonymous records

Type alias (lol):

Expression with multiple labels:

Expression with single label:

FSI formatting:

• Remove semicolons from formatting for Records
• Spaces between braces for Records
• Adjust semicolons and colons for Anonymous Records
• Spaces between braces for Anonymous Records
• Spaces between braces and removed semicolons for values in FSI
• Place colon directly after value name in FSI
• Update all tests

[auduchinok]

Could we also have a single space between braces and fields as it's usually formatted currently?

[smoothdeveloper]

Is there going to be other changes to harmonize what the "canonical" representation of the types looks like in the tooltips?

[TIHan]

I like the change. Just need to fix some of the test failures related to it.

[dsyme]

Thank you, this is a great change. Little things like this area really important!

[cartermp]

Just need to figure out how to make this dang fsharpqa test pass; there's nothing in the log (@forki pointed this out here: #7066)

@dsyme / @KevinRansom since I've zero familiarity with this old test suite, would any of you have an idea?

[dsyme]

This is the failing test:

Printing (BindingsWithValues01.fsx) -- failed

That might be enough to track it down?

[forki]

The build is writing down which test fails. But we can't see the reason. So we have to try to reproduce locally. Which can be really hard. It would be really useful if the failed assertion would be printed as well.

[cartermp]

Yep, as @forki said. Especially with this it's a game of whack-a mole, since I already modified everything that I thought was relevant in that test, but it still failed.

And it happens to not be well-factored, so I don't know which if the many cases is still failing.

[dsyme]

The build is writing down which test fails. But we can't see the reason. So we have to try to reproduce locally. Which can be really hard. It would be really useful if the failed assertion would be printed as well.

Yeah I know, it sucks.

I tend to run the commands implied by the Env.lst by hand when this happens

[cartermp]

@dsyme quick questions: we currently format records in two places:

fsharp/src/fsharp/NicePrint.fs

Lines 1740 to 1743 in 77b5521

	| TRecdRepr _ ->
	let recdFieldRefL fld = layoutRecdField false denv fld ^^ rightL (tagPunctuation ";")
	let recdL = tycon.TrueFieldsAsList |> List.map recdFieldRefL |> applyMaxMembers denv.maxMembers |> aboveListL |> braceL
	Some (addMembersAsWithEnd (addReprAccessL recdL))

and

fsharp/src/utils/sformat.fs

Lines 762 to 773 in 77b5521

	let makeRecordVerticalL nameXs =
	let itemL (name,xL) = let labelL = wordL name in ((labelL ^^ wordL Literals.equals)) -- (xL ^^ (rightL Literals.semicolon))
	let braceL xs = (leftL Literals.leftBrace) ^^ xs ^^ (rightL Literals.rightBrace)
	braceL (aboveListL (List.map itemL nameXs))
	// This is a more compact rendering of records - and is more like tuples
	let makeRecordHorizontalL nameXs =
	let itemL (name,xL) = let labelL = wordL name in ((labelL ^^ wordL Literals.equals)) -- xL
	let braceL xs = (leftL Literals.leftBrace) ^^ xs ^^ (rightL Literals.rightBrace)
	braceL (sepListL (rightL Literals.semicolon) (List.map itemL nameXs))
	let makeRecordL nameXs = makeRecordVerticalL nameXs

Any reason why this is split in these two places? The latter is used seemingly only by FSI when printing out the value of something.

[cartermp]

Okay, I'm going to ignore value printing for now and file a separate issue, as that all goes through separate code paths

[cartermp]

All green. @TIHan @KevinRansom PTAL

[dsyme]

Any reason why this is split in these two places? The latter is used seemingly only by FSI when printing out the value of something.

One is incorporated into FSharp.Core - the other is in FSharp.Compiler.

[cartermp]

I'll also fix #7163 in here since it's easy enough

[dsyme]

Another one I noticed was that val x : int in output has a space between x and :, when we normally don't have that space in F# formatting conventions.

[cartermp]

I can git that 'uhn

[cartermp]

#7196 (comment)

[cartermp]

omg it's green @TIHan @KevinRansom