Skip to content

Commit

Permalink
Revert "Use netcoreapp3.1 in tests as well"
Browse files Browse the repository at this point in the history
This reverts commit be78be4.
  • Loading branch information
vzarytovskii committed Jun 16, 2020
1 parent be78be4 commit 2538d20
Show file tree
Hide file tree
Showing 3 changed files with 86 additions and 86 deletions.
22 changes: 11 additions & 11 deletions tests/FSharp.Test.Utilities/Utilities.fs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module Utilities =
[<RequireQualifiedAccess>]
type TargetFramework =
| NetStandard20
| NetCoreApp31
| NetCoreApp30

module private TestReferences =

Expand All @@ -30,13 +30,13 @@ module Utilities =
let systemDynamicRuntimeRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netstandard20.System_Dynamic_Runtime).GetReference(display = "System.Dynamic.Runtime.dll (netstandard 2.0 ref)")

[<RequireQualifiedAccess>]
module NetCoreApp31 =
let netStandard = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp31.netstandard).GetReference(display = "netstandard.dll (netcoreapp 3.1 ref)")
let mscorlibRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp31.mscorlib).GetReference(display = "mscorlib.dll (netcoreapp 3.1 ref)")
let systemRuntimeRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp31.System_Runtime).GetReference(display = "System.Runtime.dll (netcoreapp 3.1 ref)")
let systemCoreRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp31.System_Core).GetReference(display = "System.Core.dll (netcoreapp 3.1 ref)")
let systemDynamicRuntimeRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp31.System_Dynamic_Runtime).GetReference(display = "System.Dynamic.Runtime.dll (netcoreapp 3.1 ref)")
let systemConsoleRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp31.System_Console).GetReference(display = "System.Console.dll (netcoreapp 3.1 ref)")
module NetCoreApp30 =
let netStandard = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp30.netstandard).GetReference(display = "netstandard.dll (netcoreapp 3.0 ref)")
let mscorlibRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp30.mscorlib).GetReference(display = "mscorlib.dll (netcoreapp 3.0 ref)")
let systemRuntimeRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp30.System_Runtime).GetReference(display = "System.Runtime.dll (netcoreapp 3.0 ref)")
let systemCoreRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp30.System_Core).GetReference(display = "System.Core.dll (netcoreapp 3.0 ref)")
let systemDynamicRuntimeRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp30.System_Dynamic_Runtime).GetReference(display = "System.Dynamic.Runtime.dll (netcoreapp 3.0 ref)")
let systemConsoleRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netcoreapp30.System_Console).GetReference(display = "System.Console.dll (netcoreapp 3.0 ref)")

[<RequireQualifiedAccess>]
module private TargetFrameworkUtil =
Expand All @@ -45,13 +45,13 @@ module Utilities =

let private netStandard20References =
lazy ImmutableArray.Create(NetStandard20.netStandard.Value, NetStandard20.mscorlibRef.Value, NetStandard20.systemRuntimeRef.Value, NetStandard20.systemCoreRef.Value, NetStandard20.systemDynamicRuntimeRef.Value)
let private netCoreApp31References =
lazy ImmutableArray.Create(NetCoreApp31.netStandard.Value, NetCoreApp31.mscorlibRef.Value, NetCoreApp31.systemRuntimeRef.Value, NetCoreApp31.systemCoreRef.Value, NetCoreApp31.systemDynamicRuntimeRef.Value, NetCoreApp31.systemConsoleRef.Value)
let private netCoreApp30References =
lazy ImmutableArray.Create(NetCoreApp30.netStandard.Value, NetCoreApp30.mscorlibRef.Value, NetCoreApp30.systemRuntimeRef.Value, NetCoreApp30.systemCoreRef.Value, NetCoreApp30.systemDynamicRuntimeRef.Value, NetCoreApp30.systemConsoleRef.Value)

let internal getReferences tf =
match tf with
| TargetFramework.NetStandard20 -> netStandard20References.Value
| TargetFramework.NetCoreApp31 -> netCoreApp31References.Value
| TargetFramework.NetCoreApp30 -> netCoreApp30References.Value

type RoslynLanguageVersion = LanguageVersion

Expand Down
2 changes: 1 addition & 1 deletion tests/fsharp/Compiler/Language/ByrefTests.fs
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ type MyClass() =
"""

let csCmpl =
CompilationUtil.CreateCSharpCompilation(cs, CSharpLanguageVersion.CSharp8, TargetFramework.NetCoreApp31)
CompilationUtil.CreateCSharpCompilation(cs, CSharpLanguageVersion.CSharp8, TargetFramework.NetCoreApp30)
|> CompilationReference.Create

let fsCmpl =
Expand Down
Loading

0 comments on commit 2538d20

Please sign in to comment.