Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu-libs in Alpine SDK but not runtime #2365

Closed
brettrowberry opened this issue Nov 7, 2020 · 6 comments
Closed

icu-libs in Alpine SDK but not runtime #2365

brettrowberry opened this issue Nov 7, 2020 · 6 comments

Comments

@brettrowberry
Copy link

Describe the Problem

In .NET 5 Alpine SDK images, icu-libs are included - but not in the runtime images.

Describe the Solution

Include or remove icu-libs from both images.

Additional Context

See https://andrewlock.net/dotnet-core-docker-and-cultures-solving-culture-issues-porting-a-net-core-app-from-windows-to-linux/

@brettrowberry brettrowberry changed the title icu-libs in both SDK and runtime images or neither icu-libs in Alpine SDK but not runtime Nov 7, 2020
@richlander
Copy link
Member

Good issue. We need to make a final decision on #1877 within the 6.0 release. That will help us resolve this issue.

@MichaelSimons MichaelSimons added this to the 6.0 milestone Nov 11, 2020
@brettrowberry
Copy link
Author

brettrowberry commented Nov 12, 2020

Thanks @richlander! I want the leanest .NET 5 (and beyond) images I can get. I want to minimize local dev setup time and CI build time.

@brettrowberry
Copy link
Author

And I don’t want different behavior building/testing apps vs running them!

@richlander
Copy link
Member

I agree with both of those sentiments! We'll see what we can do.

@mthalman mthalman moved this to Backlog in .NET Docker Dec 1, 2021
@mthalman mthalman modified the milestones: 6.0, .NET 8 Oct 19, 2022
@mthalman
Copy link
Member

I think the key here is with the setting of DOTNET_SYSTEM_GLOBALIZATION_INVARIANT to false. We can control that in the SDK by not setting that way. We can also avoid explicitly installing icu, but we can't necessarily guarantee that it won't exist due to a dependency on some other package that we do install. For example, in the sdk we install git. Today it doesn't have a dependency on icu but we can't necessarily guarantee it won't some day.

@lbussell
Copy link
Contributor

Alpine images with ICU libs are now available with the -extra image variant: https://github.com/dotnet/dotnet-docker/blob/main/documentation/image-variants.md#extra-net-80

@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Docker Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants