From 30e2885783bca9aa7f537d06d8815ffd9f66e211 Mon Sep 17 00:00:00 2001
From: Yufei Huang <yufeih@live.com>
Date: Mon, 19 Dec 2022 09:32:35 +0800
Subject: [PATCH] chore!: drop _docfxVersion in generated HTML

---
 .../default/partials/_head.liquid             | 23 +++++++++----------
 .../default/partials/head.tmpl.partial        |  1 -
 src/docfx/SubCommands/BuildCommand.cs         | 14 -----------
 3 files changed, 11 insertions(+), 27 deletions(-)

diff --git a/src/docfx.website.themes/default/partials/_head.liquid b/src/docfx.website.themes/default/partials/_head.liquid
index 2af71a645e8..cf5ecb8fa23 100644
--- a/src/docfx.website.themes/default/partials/_head.liquid
+++ b/src/docfx.website.themes/default/partials/_head.liquid
@@ -3,23 +3,22 @@
   <meta charset="utf-8">
   <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
   {%- if title and _appTitle -%}
-  <title>{{title}} | {{appTitle}}</title>
-  <meta name="title" content="{{title}} | {{appTitle}}">
+    <title>{{ title }} | {{ appTitle }}</title>
+    <meta name="title" content="{{title}} | {{appTitle}}">
   {%- else -%}
     {%- if title or _appTitle -%}
-  <title>{{title}}{{appTitle}}</title>
-  <meta name="title" content="{{title}}{{appTitle}}">
+      <title>{{ title }}{{ appTitle }}</title>
+      <meta name="title" content="{{title}}{{appTitle}}">
     {%- endif -%}
   {%- endif -%}
   <meta name="viewport" content="width=device-width">
-  <meta name="generator" content="docfx {{_docfxVersion}}">
   {%- if _description -%}
-  <meta name="description" content="{{_description}}">
+    <meta name="description" content="{{_description}}">
   {%- endif -%}
   {%- if _appFaviconPath -%}
-  <link rel="shortcut icon" href="{{_rel}}{{_appFaviconPath}}">
+    <link rel="shortcut icon" href="{{_rel}}{{_appFaviconPath}}">
   {%- else -%}
-  <link rel="shortcut icon" href="{{_rel}}favicon.ico">
+    <link rel="shortcut icon" href="{{_rel}}favicon.ico">
   {%- endif -%}
   <link rel="stylesheet" href="{{_rel}}styles/docfx.vendor.css">
   <link rel="stylesheet" href="{{_rel}}styles/docfx.css">
@@ -27,12 +26,12 @@
   <meta property="docfx:navrel" content="{{_navRel}}">
   <meta property="docfx:tocrel" content="{{_tocRel}}">
   {%- if _noindex -%}
-  <meta name="searchOption" content="noindex">
+    <meta name="searchOption" content="noindex">
   {%- endif -%}
   {%- if _enableSearch -%}
-  <meta property="docfx:rel" content="{{_rel}}">
+    <meta property="docfx:rel" content="{{_rel}}">
   {%- endif -%}
   {%- if _enableNewTab -%}
-  <meta property="docfx:newtab" content="true">
+    <meta property="docfx:newtab" content="true">
   {%- endif -%}
-</head>
+</head>
\ No newline at end of file
diff --git a/src/docfx.website.themes/default/partials/head.tmpl.partial b/src/docfx.website.themes/default/partials/head.tmpl.partial
index 4e8cd7918b1..c9357ca2b71 100644
--- a/src/docfx.website.themes/default/partials/head.tmpl.partial
+++ b/src/docfx.website.themes/default/partials/head.tmpl.partial
@@ -6,7 +6,6 @@
   <title>{{#title}}{{title}}{{/title}}{{^title}}{{>partials/title}}{{/title}} {{#_appTitle}}| {{_appTitle}} {{/_appTitle}}</title>
   <meta name="viewport" content="width=device-width">
   <meta name="title" content="{{#title}}{{title}}{{/title}}{{^title}}{{>partials/title}}{{/title}} {{#_appTitle}}| {{_appTitle}} {{/_appTitle}}">
-  <meta name="generator" content="docfx {{_docfxVersion}}">
   {{#_description}}<meta name="description" content="{{_description}}">{{/_description}}
   <link rel="shortcut icon" href="{{_rel}}{{{_appFaviconPath}}}{{^_appFaviconPath}}favicon.ico{{/_appFaviconPath}}">
   <link rel="stylesheet" href="{{_rel}}styles/docfx.vendor.css">
diff --git a/src/docfx/SubCommands/BuildCommand.cs b/src/docfx/SubCommands/BuildCommand.cs
index 50e3e29afc2..c8f5b4eeee3 100644
--- a/src/docfx/SubCommands/BuildCommand.cs
+++ b/src/docfx/SubCommands/BuildCommand.cs
@@ -18,8 +18,6 @@ namespace Microsoft.DocAsCode.SubCommands
 
     internal sealed class BuildCommand : ISubCommand
     {
-        private readonly string _version;
-
         private readonly TemplateManager _templateManager;
 
         public string Name { get; } = nameof(BuildCommand);
@@ -33,7 +31,6 @@ public BuildCommand(BuildJsonConfig config)
             Config = config;
 
             var assembly = typeof(Program).Assembly;
-            _version = EnvironmentContext.Version;
 
             SetDefaultConfigValue(Config);
 
@@ -75,17 +72,6 @@ private void SetDefaultConfigValue(BuildJsonConfig config)
             {
                 Config.Templates = new ListWithStringFallback { DocAsCode.Constants.DefaultTemplateName };
             }
-            if (config.GlobalMetadata == null)
-            {
-                config.GlobalMetadata = new Dictionary<string, object>
-                {
-                    ["_docfxVersion"] = _version
-                };
-            }
-            else if (!config.GlobalMetadata.ContainsKey("_docfxVersion"))
-            {
-                config.GlobalMetadata["_docfxVersion"] = _version;
-            }
         }
 
         /// <summary>