Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SOS diagnostics for OSR methods #2992

Open
jakobbotsch opened this issue Apr 7, 2022 · 2 comments
Open

Improve SOS diagnostics for OSR methods #2992

jakobbotsch opened this issue Apr 7, 2022 · 2 comments
Assignees
@AndyAyersMS
Labels
enhancement New feature or request sos
Milestone
Future

Comments

@jakobbotsch
Copy link
Member

It would be very useful if SOS reported either IL offsets or IP for the patchpoint that was triggered in the output of dumpmd/ip2md. Otherwise it is very hard to reconcile the codegen seen in these methods with the original IL. In dotnet/runtime#66983 I ended up tracking this down by doing several pointer searches through memory to find the key of the PerPatchpointInfo structure.

cc @AndyAyersMS
@ghost
Copy link

ghost commented Apr 7, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

It would be very useful if SOS reported either IL offsets or IP for the patchpoint that was triggered in the output of dumpmd/ip2md. Otherwise it is very hard to reconcile the codegen seen in these methods with the original IL. In dotnet/runtime#66983 I ended up tracking this down by doing several pointer searches through memory to find the key of the PerPatchpointInfo structure.

cc @AndyAyersMS

Author: jakobbotsch
Assignees: -
Labels:

area-Diagnostics-coreclr, untriaged
Milestone: -

@tommcdon tommcdon transferred this issue from dotnet/runtime Apr 7, 2022
@tommcdon tommcdon added this to the .NET 7.0 milestone Apr 7, 2022
@tommcdon
Copy link
Member

tommcdon commented Apr 7, 2022

@mikem8361

@tommcdon tommcdon removed the untriaged label Apr 7, 2022
@mikem8361 mikem8361 added the enhancement New feature or request label Apr 7, 2022
@mikem8361 mikem8361 assigned mikem8361 and AndyAyersMS and unassigned mikem8361 Apr 11, 2022
@tommcdon tommcdon modified the milestones: 7.0.0, 8.0.0 Sep 12, 2022
@tommcdon tommcdon modified the milestones: 8.0.0, Future Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyAyersMS AndyAyersMS

Labels
enhancement New feature or request sos
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@jakobbotsch @AndyAyersMS @mikem8361 @tommcdon