Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the mapping between tuple types and ValueTuple normatively. #876

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Specify the mapping between tuple types and ValueTuple normatively. #876

merged 3 commits into from
Aug 14, 2023

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Aug 7, 2023

Alternative to #798.

@jskeet jskeet changed the title Specify the mapping between tuple types ValueTuple normatively. Specify the mapping between tuple types and ValueTuple normatively. Aug 7, 2023
@jskeet jskeet changed the title Specify the mapping between tuple types and ValueTuple normatively. Specify the mapping between tuple types and ValueTuple normatively. Aug 7, 2023
@jskeet jskeet mentioned this pull request Aug 7, 2023
Closed
KalleOlaviNiemitalo
KalleOlaviNiemitalo suggested changes Aug 7, 2023
View reviewed changes
standard/types.md Outdated Show resolved Hide resolved
KalleOlaviNiemitalo
KalleOlaviNiemitalo suggested changes Aug 7, 2023
View reviewed changes
standard/types.md Outdated Show resolved Hide resolved
@KalleOlaviNiemitalo
Copy link
Contributor

The "shorthand" term feels a bit wrong because these types have identity conversions between them but are not the same type. It's not the same situation as with int vs. global::System.Int32. The distinction is explained in more detail later though so it could be ok.

Nigel-Ecma
Nigel-Ecma approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clear, straightforward.

BillWagner
BillWagner approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clear concise explanation. Thanks @jskeet

Let's :shipit:

@jskeet
Copy link
Contributor Author

jskeet commented Aug 14, 2023

Right, merging - we can go over it retrospectively, but I want to clear the decks as far as possible.

@jskeet jskeet merged commit bd47139 into dotnet:draft-v7 Aug 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalleOlaviNiemitalo KalleOlaviNiemitalo KalleOlaviNiemitalo requested changes

@BillWagner BillWagner BillWagner approved these changes

@Nigel-Ecma Nigel-Ecma Nigel-Ecma approved these changes

@MadsTorgersen MadsTorgersen Awaiting requested review from MadsTorgersen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jskeet @KalleOlaviNiemitalo @BillWagner @Nigel-Ecma