Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# v7.x: async Main #70

Merged
merged 7 commits into from
Nov 2, 2022
Merged

C# v7.x: async Main #70

merged 7 commits into from
Nov 2, 2022

Conversation

RexJaeschke
Copy link
Contributor

No description provided.

@RexJaeschke RexJaeschke added this to the C# 7.x milestone Dec 14, 2020
@RexJaeschke RexJaeschke added the Review: pending Proposal is available for review label Sep 16, 2021
@RexJaeschke RexJaeschke mentioned this pull request Jan 3, 2022
Open
@BillWagner BillWagner marked this pull request as draft February 3, 2022 14:51
@BillWagner
Copy link
Member

C# 7 feature: converting to a draft PR until we're ready to work on V7

@jskeet jskeet self-assigned this May 31, 2022
@jskeet
Copy link
Contributor

jskeet commented May 31, 2022

I'm going to try to review this before next week's meeting.

jskeet
jskeet reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly fine, but I'd like to discuss how we talk about the termination status code.

standard/basic-concepts.md Outdated Show resolved Hide resolved
@jskeet jskeet marked this pull request as ready for review June 8, 2022 08:34
@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Jun 8, 2022
BillWagner
BillWagner reviewed Jul 12, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one or two suggestions. Once we resolve the discussion on the compiler generated entry points, this is ready, IMO.

standard/basic-concepts.md Outdated Show resolved Hide resolved
standard/basic-concepts.md Outdated Show resolved Hide resolved
@jskeet jskeet removed the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Jul 13, 2022
@jskeet
Copy link
Contributor

jskeet commented Jul 13, 2022

Agreed with Bill's proposal to make this less normative, which side-steps some issues. Jon to propose tweaked wording, Bill will review.

@BillWagner
Copy link
Member

@jskeet

Looks like this one got dropped. It was last assigned to you for wordsmithing. I can pick up the baton for updating the text if you don't have time for it.

@jskeet
Copy link
Contributor

jskeet commented Oct 5, 2022

I've done a bit more work on this in a fifth commit, but I think we should discuss other areas - the idea that the entry point can return Task<int> is pervasive for the rest, and I think it would be useful if we could describe it just in terms of the what the synthetic entry point does instead.

@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Oct 5, 2022
jskeet
jskeet reviewed Oct 5, 2022
View reviewed changes
standard/basic-concepts.md Outdated Show resolved Hide resolved
@BillWagner
Copy link
Member

closing and reopening to re-run all actions.

@BillWagner BillWagner closed this Oct 12, 2022
@BillWagner BillWagner reopened this Oct 12, 2022
jskeet
jskeet reviewed Oct 26, 2022
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now ready for another review - I believe it handles everything.

standard/basic-concepts.md Outdated Show resolved Hide resolved
standard/basic-concepts.md Outdated Show resolved Hide resolved
standard/basic-concepts.md Outdated Show resolved Hide resolved
standard/basic-concepts.md Outdated Show resolved Hide resolved
standard/basic-concepts.md Show resolved Hide resolved
standard/basic-concepts.md Show resolved Hide resolved
@jskeet @BillWagner
Update standard/basic-concepts.md
81e0357 
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
BillWagner
BillWagner approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jskeet
Copy link
Contributor

jskeet commented Nov 2, 2022

Agreed on the call.

@jskeet jskeet merged commit e891a15 into draft-v7 Nov 2, 2022
@jskeet jskeet deleted the Rex-v7-async-Main branch November 2, 2022 20:40
BillWagner added a commit to BillWagner/docs that referenced this pull request Nov 4, 2022
@BillWagner
remove async main speclet
736e433 
This can be removed, as the updates were approved in the last C# standards meeting.

See dotnet/csharpstandard#70
@BillWagner BillWagner mentioned this pull request Nov 4, 2022
Merged
BillWagner added a commit to dotnet/docs that referenced this pull request Nov 7, 2022
@BillWagner
remove async main speclet (#32205)
d2f5a58 
* remove async main speclet

This can be removed, as the updates were approved in the last C# standards meeting.

See dotnet/csharpstandard#70

* add redirection

* fix redirection.

* fix redirection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet left review comments

@KalleOlaviNiemitalo KalleOlaviNiemitalo KalleOlaviNiemitalo left review comments

@BillWagner BillWagner BillWagner approved these changes

Assignees

@jskeet jskeet

Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting Review: pending Proposal is available for review
Projects
None yet
Milestone
C# 7.x
Development

Successfully merging this pull request may close these issues.
4 participants
@RexJaeschke @BillWagner @jskeet @KalleOlaviNiemitalo