-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for default interface function members #681
Open
RexJaeschke
wants to merge
12
commits into
dotnet:draft-v8
Choose a base branch
from
RexJaeschke:default-interface-function-members
base: draft-v8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding support for default interface function members #681
RexJaeschke
wants to merge
12
commits into
dotnet:draft-v8
from
RexJaeschke:default-interface-function-members
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending how PR #680 is resolved, some tweaks might be needed with this PR. As at 2024-01-11, that PR is still pending, and is tied to the review of this PR. |
BillWagner
force-pushed
the
default-interface-function-members
branch
from
February 6, 2023 13:52
84a1703
to
caba5c7
Compare
BillWagner
force-pushed
the
default-interface-function-members
branch
from
September 25, 2023 20:54
caba5c7
to
dc8d7a0
Compare
rebased on the latest draft-v8 on 09-23-2023 |
Should the references to "C# implementations targeting the CLI" be changed somehow because the ECMA standard CLI does not support default interface members? Possible answers include:
|
Enclosing a paragraph in brackets breaks the word converter. It looks for a link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re the MS proposal: The main challenge when reading it was the (misleading) occurrence of the modifier
override
in numerous examples and narrative. As best as I can tell, this modifier is not actually permitted on any interface member. Instead, overriding is achieved via explicit implementation.There is one open question, which has to do with the topic "Base Interface Invocations," for which the decision "Decided on
base(N.I1<T>).M(s)
" was made. However, as far as I can tell, support for this was not added to the V8 compiler. Can someone please confirm (or refute) that.BTW, I think the proposal is misnamed: it really applies to all interface function members (properties, indexers, and events as well), not just methods. (it also allows nested types.)
Note: No spec changes are needed to support entry point
Main
in an interface. Any non-generic type containing aMain
method withvoid
/int
return and no/onestring[]
parameter list is already permitted, which not only allowsMain
in a struct or class, but now also in an interface.