-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discards, tuples and out variables #664
Merged
MadsTorgersen
merged 45 commits into
draft-v7
from
Mads-v7-local-declarations-in-expressions
Apr 6, 2023
Merged
Discards, tuples and out variables #664
MadsTorgersen
merged 45 commits into
draft-v7
from
Mads-v7-local-declarations-in-expressions
Apr 6, 2023
Commits on Nov 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b51c0cf - Browse repository at this point
Copy the full SHA b51c0cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e9bcda - Browse repository at this point
Copy the full SHA 0e9bcdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6a30bc - Browse repository at this point
Copy the full SHA c6a30bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bea703 - Browse repository at this point
Copy the full SHA 4bea703View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9152a7 - Browse repository at this point
Copy the full SHA c9152a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7908b94 - Browse repository at this point
Copy the full SHA 7908b94View commit details
Commits on Nov 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 97bfb5c - Browse repository at this point
Copy the full SHA 97bfb5cView commit details
Commits on Nov 30, 2022
-
Make sure evaluation order is described precisely in deconstructing assignments.
Configuration menu - View commit details
-
Copy full SHA for fc50f9c - Browse repository at this point
Copy the full SHA fc50f9cView commit details
Commits on Jan 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7b553a0 - Browse repository at this point
Copy the full SHA 7b553a0View commit details -
Apply suggestions from code review
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 5b1c905 - Browse repository at this point
Copy the full SHA 5b1c905View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05821a9 - Browse repository at this point
Copy the full SHA 05821a9View commit details -
Merge branch 'Mads-v7-local-declarations-in-expressions' of https://g…
…ithub.com/dotnet/csharpstandard into Mads-v7-local-declarations-in-expressions
Configuration menu - View commit details
-
Copy full SHA for cb6ce12 - Browse repository at this point
Copy the full SHA cb6ce12View commit details -
Configuration menu - View commit details
-
Copy full SHA for f67f61d - Browse repository at this point
Copy the full SHA f67f61dView commit details
Commits on Jan 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7114566 - Browse repository at this point
Copy the full SHA 7114566View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d75674 - Browse repository at this point
Copy the full SHA 4d75674View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2048881 - Browse repository at this point
Copy the full SHA 2048881View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7896208 - Browse repository at this point
Copy the full SHA 7896208View commit details
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eeec248 - Browse repository at this point
Copy the full SHA eeec248View commit details -
Configuration menu - View commit details
-
Copy full SHA for 231a77e - Browse repository at this point
Copy the full SHA 231a77eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25d39d0 - Browse repository at this point
Copy the full SHA 25d39d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fb99c1 - Browse repository at this point
Copy the full SHA 0fb99c1View commit details
Commits on Feb 9, 2023
-
Deconstructing assignment is now fully integrated into simple assignment, and doesn't have its own section. Deconstruction itself has been broken into an independent subsection of Expressions in anticipation of more deconstruction to come in future releases. The evaluation order of a deconstructing assignment is now elegant and recursive. However, it still does not match the compiler behavior 100%. The evaluation order of the expressions directly occurring in the assignment expression is correct (except for what seems to be a compiler bug in a very specific case). However, in the case of nested left side tuples, some conversions and deconstructions may occur slightly later than my text implies. I've chosen to live with this difference since it is small, unobservable when the conversions and deconstructions are side-effect free (as they should be), and frankly beyond my capabilities to adequately overcome.
Configuration menu - View commit details
-
Copy full SHA for 26d24a3 - Browse repository at this point
Copy the full SHA 26d24a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1107b68 - Browse repository at this point
Copy the full SHA 1107b68View commit details -
Configuration menu - View commit details
-
Copy full SHA for d180df7 - Browse repository at this point
Copy the full SHA d180df7View commit details
Commits on Feb 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 39a3c1a - Browse repository at this point
Copy the full SHA 39a3c1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02b0dc7 - Browse repository at this point
Copy the full SHA 02b0dc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b67781 - Browse repository at this point
Copy the full SHA 2b67781View commit details
Commits on Mar 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3231f81 - Browse repository at this point
Copy the full SHA 3231f81View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb94c3f - Browse repository at this point
Copy the full SHA eb94c3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97379cb - Browse repository at this point
Copy the full SHA 97379cbView commit details
Commits on Mar 21, 2023
-
Fix declaration expressions and overload resolution
I've further unified `_` discards and declaration expressions. Furthermore I've changed the approach to overload resolution. The change is small but radical, leaving out all `out` and `ref` parameters entirely from parameter-wise betterness! I believe this is sound, since out and ref arguments are always required to match precisely, so one is never better than the other. However, the desired effect was just to ensure that declaration expressions do not influence betterness. If we don't like this fix we can reduce its scope to a bigger change with smaller consequences. ;-)
Configuration menu - View commit details
-
Copy full SHA for d48514a - Browse repository at this point
Copy the full SHA d48514aView commit details -
Root declaration_expression as a non_assignment_expression and adjust verbiage accordingly in various places.
Configuration menu - View commit details
-
Copy full SHA for 8737fc4 - Browse repository at this point
Copy the full SHA 8737fc4View commit details
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5f62fd2 - Browse repository at this point
Copy the full SHA 5f62fd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 218921f - Browse repository at this point
Copy the full SHA 218921fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 205760f - Browse repository at this point
Copy the full SHA 205760fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 978b3dc - Browse repository at this point
Copy the full SHA 978b3dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c36dc0b - Browse repository at this point
Copy the full SHA c36dc0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4cfcc8 - Browse repository at this point
Copy the full SHA f4cfcc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1316315 - Browse repository at this point
Copy the full SHA 1316315View commit details -
Configuration menu - View commit details
-
Copy full SHA for 797c301 - Browse repository at this point
Copy the full SHA 797c301View commit details -
Co-authored-by: Nigel-Ecma <perryresearch@zoot.net.nz>
Configuration menu - View commit details
-
Copy full SHA for 938205b - Browse repository at this point
Copy the full SHA 938205bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e94899 - Browse repository at this point
Copy the full SHA 8e94899View commit details -
Merge branch 'Mads-v7-local-declarations-in-expressions' of https://g…
…ithub.com/dotnet/csharpstandard into Mads-v7-local-declarations-in-expressions
Configuration menu - View commit details
-
Copy full SHA for 40127a2 - Browse repository at this point
Copy the full SHA 40127a2View commit details
Commits on Apr 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b0de44f - Browse repository at this point
Copy the full SHA b0de44fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bfcb45 - Browse repository at this point
Copy the full SHA 5bfcb45View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.