Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdownlint final fixes #532

Merged
merged 23 commits into from
Mar 28, 2022
Merged

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Mar 25, 2022

This fixes all the warnings for MD030 (code fenced sections should be surrounded by blank lines.

There's one commit per file. The diffs are somewhat large, but should be trivial to examine visually. This was the lint warning our spec generated the most. 😓 But now, I think we're in a good place. 😀

@BillWagner BillWagner marked this pull request as draft March 25, 2022 21:37
@BillWagner
Copy link
Member Author

Reverting to draft status.

@jskeet This one caused an exception in the word converter. I'll do some investigation to figure out why.

@BillWagner BillWagner marked this pull request as ready for review March 25, 2022 22:05
@BillWagner
Copy link
Member Author

The word converter errors were because of typos while working on this warning. We should be good now.

standard/attributes.md Outdated Show resolved Hide resolved
standard/statements.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll admit I haven't carefully checked every line insertion, but it looks fine with the exception of one rogue deletion which I'm expecting was a mistake.

standard/statements.md Outdated Show resolved Hide resolved
@BillWagner
Copy link
Member Author

Great catch @jskeet I fixed that, and then gave the diffs one more proofread. I didn't find any other changes.

I'll :shipit: now.

@BillWagner BillWagner merged commit cf5a3d9 into dotnet:draft-v6 Mar 28, 2022
@BillWagner BillWagner deleted the markdownlint-final branch March 28, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants