Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Section renumber and grammar extraction #519

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

github-actions[bot]
Copy link
Contributor

renumber sections. Add grammar

Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not merge this. The table is deliberately indented as it's part of a list bullet. We may need Smarten changes to handle this...

@BillWagner
Copy link
Member

ping @Nigel-Ecma

@github-actions github-actions bot force-pushed the create-pull-request/patch branch 3 times, most recently from df7eead to f677661 Compare March 18, 2022 15:06
@BillWagner
Copy link
Member

@jskeet @Nigel-Ecma

One option (for the short term) is to turn off the smarten task. We'd continue to update the TOC and the grammar by merging these automated PRs, but a few non-smart quotes would sneak in. As long as we fix the root issue before we submit the final, we should be fine. Thoughts?

@jskeet
Copy link
Contributor

jskeet commented Mar 18, 2022

Maybe convert it from auto-run to manually-invoked - then we can run it once in a while (e.g. before submission) and pull/fix/push to undo anything we don't want. I think I'd still like the task itself to be run in a CI way rather than by individuals.

@github-actions github-actions bot force-pushed the create-pull-request/patch branch 2 times, most recently from 0f807b3 to 3db0844 Compare March 18, 2022 21:34
@Nigel-Ecma
Copy link
Contributor

@jskeet @BillWagner – I've just checked in a Markdig fix for HTML blocks in lists. Smarten is again working without roundtrip errors on draft-v6.

@jskeet
Copy link
Contributor

jskeet commented Mar 19, 2022

Thanks @Nigel-Ecma!

@BillWagner
Copy link
Member

Thanks @Nigel-Ecma

I'll make a PR that updates the smarten tar file.

@github-actions github-actions bot force-pushed the create-pull-request/patch branch 6 times, most recently from 0c6e456 to 7cdd334 Compare March 24, 2022 12:21
@BillWagner
Copy link
Member

@jskeet

The job runs and updates this branch on each update. Now that smarten isn't part of the "update on merge" workflow, this can be merged.

More importantly, when we merge the better-betterness PR, we'll want to update the TOC.

@BillWagner BillWagner merged commit 7c6320e into draft-v6 Mar 24, 2022
@BillWagner BillWagner deleted the create-pull-request/patch branch March 24, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants