-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Section renumber and grammar extraction #519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not merge this. The table is deliberately indented as it's part of a list bullet. We may need Smarten changes to handle this...
6cb118f
to
a06a087
Compare
ping @Nigel-Ecma |
df7eead
to
f677661
Compare
One option (for the short term) is to turn off the smarten task. We'd continue to update the TOC and the grammar by merging these automated PRs, but a few non-smart quotes would sneak in. As long as we fix the root issue before we submit the final, we should be fine. Thoughts? |
Maybe convert it from auto-run to manually-invoked - then we can run it once in a while (e.g. before submission) and pull/fix/push to undo anything we don't want. I think I'd still like the task itself to be run in a CI way rather than by individuals. |
0f807b3
to
3db0844
Compare
@jskeet @BillWagner – I've just checked in a Markdig fix for HTML blocks in lists. Smarten is again working without roundtrip errors on draft-v6. |
Thanks @Nigel-Ecma! |
Thanks @Nigel-Ecma I'll make a PR that updates the smarten tar file. |
0c6e456
to
7cdd334
Compare
7cdd334
to
4685b9d
Compare
The job runs and updates this branch on each update. Now that smarten isn't part of the "update on merge" workflow, this can be merged. More importantly, when we merge the better-betterness PR, we'll want to update the TOC. |
renumber sections. Add grammar