Rex fix formatting nits #403

RexJaeschke · 2021-11-18T20:42:38Z

@jskeet This one can now be merged.

jskeet · 2021-12-15T20:41:44Z

Label removed as this is a PR that Rex uses to fix typos periodically.

jskeet

Mostly fine, although there are conflicts.

standard/classes.md

jskeet · 2022-01-19T08:08:46Z

standard/classes.md


-An async function has the ability to suspend evaluation by means of await expressions ([§12.8.8](expressions.md#1288-await-expressions)) in its body. Evaluation may later be resumed at the point of the suspending await expression by means of a ***resumption delegate***. The resumption delegate is of type `System.Action`, and when it is invoked, evaluation of the async function invocation will resume from the await expression where it left off. The ***current caller*** of an async function invocation is the original caller if the function invocation has never been suspended or the most recent caller of the resumption delegate otherwise.
+An async function has the ability to suspend evaluation by means of await expressions in its body. Evaluation may later be resumed at the point of the suspending await expression by means of a ***resumption delegate***. The resumption delegate is of type `System.Action`, and when it is invoked, evaluation of the async function invocation will resume from the await expression where it left off. The ***current caller*** of an async function invocation is the original caller if the function invocation has never been suspended or the most recent caller of the resumption delegate otherwise.


Why have we removed the link here?

When resolving conflicts, I put the link back in. @RexJaeschke Does that make sense to you?

jskeet

There's still one comment about link removal, but once that's sorted I'd like to get this merged, to avoid it getting stale. (It's quite old now.) I don't know whether it's already out of date with respect to section references.

standard/classes.md

BillWagner

This LGTM.

@RexJaeschke See the one comment from Jon and I regarding removing a link.

Once we're clear there, I'll merge this.

RexJaeschke · 2022-03-18T15:01:15Z

@BillWagner The link you restored looks good, Bill. But the link-verifier failure reported above appears to be in README.md, which is not something I'm touching.

BillWagner · 2022-03-18T15:04:03Z

But the link-verifier failure reported above appears to be in README.md, which is not something I'm touching.

We need to fix that in our tooling. The links in the readme are generated by our tool. So, we don't care if they aren't correct when we remove or replace a clause. (The tool will fix it).

I'll work with @Youssef1313 to submit a PR so we can ignore bad links in that file.

Youssef1313 · 2022-03-18T15:08:31Z

@BillWagner It looks like you already fixed the failure here in #514. If the workflow was given a re-run, it would have succeeded.

Youssef1313 · 2022-03-18T15:11:18Z

Just need to make sure the tool that generates README.md doesn't overwrite the change in #514

BillWagner · 2022-03-18T15:12:17Z

@Youssef1313 Yes, this condition is self-correcting.

See #484 it reappears every time we add or remove a section, until that PR gets merged, and then the action runs to regenerate the TOC. It's a lower priority, but in time, I'd still like all the PRs to have green CI results.

Youssef1313 · 2022-03-18T15:20:13Z

While #514 was a good step in getting CI green. It's possible this fail in the future for characters that are not handled correctly (currently the ellipse was special-cased).

A more stable fix would be to replace this logic:

csharpstandard/tools/StandardAnchorTags/TocSectionNumberBuilder.cs

Lines 154 to 159 in 133725e

    
           string anchor = $"{newSectionNumber} {header.title}" 
        
               .Replace(' ', '-').Replace(".", "").Replace(",", "").Replace("`", "") 
        
               .Replace("/", "").Replace(":", "").Replace("?", "").Replace("&", "") 
        
               .Replace("|", "").Replace("!", "").Replace("\\<", "").Replace("\\>", "").Replace("\\#", "") 
        
               .Replace("…", "") 
        
               .ToLower();

with

https://github.com/xoofx/markdig/blob/0cfe6d7da48ea6621072eb50ade32141ea92bc35/src/Markdig/Helpers/LinkHelper.cs#L100-L113

I opened #520

RexJaeschke added 3 commits October 14, 2021 10:46

fix formatting nits

192f5e6

fix formatting nits

a94d635

fix formatting nits

a96f5aa

jskeet added meeting: discuss This issue should be discussed at the next TC49-TG2 meeting and removed meeting: discuss This issue should be discussed at the next TC49-TG2 meeting labels Dec 10, 2021

RexJaeschke requested a review from jskeet January 18, 2022 18:13

RexJaeschke marked this pull request as ready for review January 18, 2022 18:15

jskeet reviewed Jan 19, 2022

View reviewed changes

RexJaeschke added 4 commits March 12, 2022 14:33

Fix formatting nits

ad4040b

Fix formatting nits

c846c85

Fix formatting nits

9e62705

Fix formatting nits

153d002

jskeet reviewed Mar 14, 2022

View reviewed changes

standard/classes.md Outdated Show resolved Hide resolved

RexJaeschke requested a review from BillWagner March 17, 2022 13:42

Merge branch 'draft-v6' into Rex-fix-formatting-nits

de988e6

BillWagner approved these changes Mar 17, 2022

View reviewed changes

BillWagner merged commit 21b8817 into dotnet:draft-v6 Mar 18, 2022

BillWagner deleted the Rex-fix-formatting-nits branch March 18, 2022 15:04

KalleOlaviNiemitalo mentioned this pull request Aug 17, 2023

Code font in "type object" when an instance of System.Type is meant #905

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rex fix formatting nits #403

Rex fix formatting nits #403

RexJaeschke commented Nov 18, 2021 •

edited

Loading

jskeet commented Dec 15, 2021

jskeet left a comment

jskeet Jan 19, 2022

BillWagner Mar 17, 2022

jskeet left a comment

BillWagner left a comment

RexJaeschke commented Mar 18, 2022

BillWagner commented Mar 18, 2022

Youssef1313 commented Mar 18, 2022

Youssef1313 commented Mar 18, 2022

BillWagner commented Mar 18, 2022

Youssef1313 commented Mar 18, 2022 •

edited

Loading


		An async function has the ability to suspend evaluation by means of await expressions ([§12.8.8](expressions.md#1288-await-expressions)) in its body. Evaluation may later be resumed at the point of the suspending await expression by means of a *resumption delegate. The resumption delegate is of type `System.Action`, and when it is invoked, evaluation of the async function invocation will resume from the await expression where it left off. The current caller* of an async function invocation is the original caller if the function invocation has never been suspended or the most recent caller of the resumption delegate otherwise.
		An async function has the ability to suspend evaluation by means of await expressions in its body. Evaluation may later be resumed at the point of the suspending await expression by means of a *resumption delegate. The resumption delegate is of type `System.Action`, and when it is invoked, evaluation of the async function invocation will resume from the await expression where it left off. The current caller* of an async function invocation is the original caller if the function invocation has never been suspended or the most recent caller of the resumption delegate otherwise.

Rex fix formatting nits #403

Rex fix formatting nits #403

Conversation

RexJaeschke commented Nov 18, 2021 • edited Loading

jskeet commented Dec 15, 2021

jskeet left a comment

Choose a reason for hiding this comment

jskeet Jan 19, 2022

Choose a reason for hiding this comment

BillWagner Mar 17, 2022

Choose a reason for hiding this comment

jskeet left a comment

Choose a reason for hiding this comment

BillWagner left a comment

Choose a reason for hiding this comment

RexJaeschke commented Mar 18, 2022

BillWagner commented Mar 18, 2022

Youssef1313 commented Mar 18, 2022

Youssef1313 commented Mar 18, 2022

BillWagner commented Mar 18, 2022

Youssef1313 commented Mar 18, 2022 • edited Loading

RexJaeschke commented Nov 18, 2021 •

edited

Loading

Youssef1313 commented Mar 18, 2022 •

edited

Loading