C# 7.x: Default literals #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converting to draft: C# 7 feature |
BillWagner
force-pushed
the
Rex-v7-def-literal
branch
2 times, most recently
from
89d4a8e
to
dda7cbb
Compare
4 tasks
BillWagner
force-pushed
the
Rex-v7-def-literal
branch
from
dda7cbb
to
3d3ae0d
Compare
jskeet
reviewed
Oct 26, 2022
jskeet
added
the
meeting: discuss
Nigel-Ecma
previously requested changes
Nov 1, 2022
There was a problem hiding this comment.
Some of the phraseology doesn't match the Standard (it presumable comes from the source material) so needs changing. Further I think we should describe default similar to null for consistency.
The restrictions on the use of default_literal as the argument to unary & binary operators, as described in https://github.com/dotnet/csharplang/blob/main/meetings/2017/LDM-2017-05-31.md#default-in-operators, do not appear to be in this Standard. Where they ever added to the spec or implemented?
BillWagner
approved these changes
Nov 30, 2022
|
closing and reopening to trigger actions. |
jskeet
reviewed
Nov 30, 2022
jskeet
reviewed
Nov 30, 2022
jskeet
reviewed
Nov 30, 2022
jskeet
reviewed
Nov 30, 2022
jskeet
reviewed
Nov 30, 2022
jskeet
approved these changes
Nov 30, 2022
jskeet
dismissed
Nigel-Ecma’s stale review
We have fixed everything. (Nigel isn't here to approve, but we'd like to merge. We're confident.)
BillWagner
approved these changes
Nov 30, 2022
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
Dec 1, 2022
The standard committe has merged the updates to the standard for the following features: - dotnet/csharpstandard#216 - non-trailing named arguments - dotnet/csharpstandard#236 - default literals Remove the feature speclets from the publishing list, and fix any related links.
BillWagner
added a commit
to dotnet/docs
that referenced
this pull request
Dec 2, 2022
* remove feature specs The standard committe has merged the updates to the standard for the following features: - dotnet/csharpstandard#216 - non-trailing named arguments - dotnet/csharpstandard#236 - default literals Remove the feature speclets from the publishing list, and fix any related links. * add redirections Add the redirections for removed proposal specs. * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the V7 proposal discussed in Issue #67.