Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate term definitions for Classes #206

Conversation

RexJaeschke
Copy link
Contributor

@BillWagner: I think I made this more complicated than need be. The text I needed to edit was in branch feature-expression-bodied-members (which feeds into the pending PR #4), and I started with that as base. But instead of saving it back to that branch, I saved it to new branch Rex-resolve-term-dupe-defs-in-classes. And now I have this new PR to make that change. Presumably, I should have smuggled this change on the back of PR 4.

This PR addresses part 2 of 2 in Issue #40.

@RexJaeschke RexJaeschke added this to the C# 6 milestone Jan 14, 2021
@RexJaeschke RexJaeschke changed the title Update classes.md Remove duplicate term definitions for Classes Jan 14, 2021
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @RexJaeschke

You can :shipit: when ready.

@RexJaeschke RexJaeschke merged commit abb347f into feature-expression-bodied-members Feb 5, 2021
@RexJaeschke RexJaeschke deleted the Rex-resolve-dupe-term-defs-in-classes branch February 5, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants