Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Word converter: "antlr" code path is never used #432

Closed
jskeet opened this issue Jan 20, 2022 · 1 comment · Fixed by #525
Closed

Word converter: "antlr" code path is never used #432

jskeet opened this issue Jan 20, 2022 · 1 comment · Fixed by #525
Labels
type: bug The Standard does not describe the language as intended or implemented type: tools This issue (or PR) relates to a tool, not the Standard

Comments

@jskeet
Copy link
Contributor

jskeet commented Jan 20, 2022

In MarkdownSourceConverter, we initially handle "antlr" and "ANTLR" the same way... but then only use "antlr" to apply the "Grammar" style. When trying to make this case-insensitive, the converter falls over entirely.

I believe we use "ANTLR" exclusively now - so it might be worth a) deciding if we want the style; b) being case-sensitive about requiring "ANTLR".
@jskeet jskeet added type: bug The Standard does not describe the language as intended or implemented type: tools This issue (or PR) relates to a tool, not the Standard labels Jan 20, 2022
@jskeet
Copy link
Contributor Author

jskeet commented Feb 24, 2022

We don't need to resolve this for C# 6.

jskeet added a commit to jskeet/csharpstandard that referenced this issue Mar 21, 2022
@jskeet
Remove last vestiges of "antlr" language for code blocks
364e2b3 
All our grammar blocks use ANTLR instead.

Fixes dotnet#432.
@jskeet jskeet mentioned this issue Mar 21, 2022
Merged
jskeet added a commit that referenced this issue Mar 21, 2022
@jskeet
Remove last vestiges of "antlr" language for code blocks
f167bfb 
All our grammar blocks use ANTLR instead.

Fixes #432.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug The Standard does not describe the language as intended or implemented type: tools This issue (or PR) relates to a tool, not the Standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove last vestiges of "antlr" language for code blocks jskeet/csharpstandard
1 participant
@jskeet