ref fields spec updates #6539
Merged
ref fields spec updates #6539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple of items: - Clarifying the rules around ref reassignment. - Affirming the *safe-to-escape* of non `ref struct`. This needed clarifying after the introduction of *return only* - Affirming the cut line for features in C# 11
jcouv
reviewed
Oct 12, 2022
| > 2. `e1 = ref e2`: where `e1` is a `ref` local or `ref` parameter then `e2` must have a *safe-to-escape* equal to *safe-to-escape* for `e1` and `e2` must have *ref-safe-to-escape* at least as large as *ref-safe-to-escape* of the *ref-safe-to-escape* of `e1` | ||
| > For a ref reassignment in the form `e1 = ref e2` both of the following must be true: | ||
| > 1. e2 must have ref-safe-to-escape at least as large as the ref-safe-to-escape of e1 | ||
| > 2. e1 must have the same safe-to-escape as e2 |
There was a problem hiding this comment.
nit: backticks on e1 and e2
nit: I'm okay to keep a side-note on x.e1 case, since I agree it is a bit tricky how it falls out.
There was a problem hiding this comment.
Yeah formatting didn't copy correctly. Will add the sample.
cston
approved these changes
Oct 12, 2022
cston
approved these changes
Oct 12, 2022
cston
reviewed
Oct 12, 2022
| Span<int> local = stackalloc int[42]; | ||
| ref Span<int> refLocal = ref local; | ||
|
|
||
| // The rule above prevent this because the safe-to-escape of the two values is |
There was a problem hiding this comment.
Suggested change
| // The rule above prevent this because the safe-to-escape of the two values is | |
| // The rule above prevents this because the safe-to-escape of the two values is |
cston
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of items:
ref struct. This needed clarifying after the introduction of return onlycloses dotnet/roslyn#64671
related dotnet/roslyn#62618