Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Fix vector tests to work on non en-US culture machines #31

Merged
merged 1 commit into from
Nov 12, 2014
Merged

Fix vector tests to work on non en-US culture machines #31

merged 1 commit into from
Nov 12, 2014

Conversation

adamralph
Copy link
Contributor

This fixes the following test failure (on my de-CH machine)

image

After the change the build succeeds.

@joshfree
Copy link
Member

LGTM. running this through our CI

@MaximRouiller
Copy link

Is that officially the first community pull request? If yes, will that be the first ACCEPTED community pull request? 👍

@nguerrera
Copy link
Contributor

@MaximRouiller Yes.

@gaearon
Copy link

gaearon commented Nov 12, 2014

👍

@FiveTimesTheFun
Copy link
Contributor

Awesome - thank you!

@mellinoe
Copy link
Contributor

Great catch, thanks for submitting this. I believe there is an analogous test in Vector4Tests.cs that needs to be changed, as well (it also tests this same case for Vector4).

👍

@damianh
Copy link

damianh commented Nov 12, 2014

@adamralph I was hoping this would be a "Remove all regions" troll PR. Much disappoint.

@dotnet-bot dotnet-bot merged commit 5ec20d0 into dotnet:master Nov 12, 2014
@adamralph adamralph deleted the fix-tests branch November 12, 2014 16:49
@davepermen
Copy link

👍 congratulations

@pgermishuys
Copy link

congrats!

@shanselman
Copy link

Woot

@hnrkndrssn
Copy link

Awesome dude!

@Stephanvs
Copy link

Haha awesome! First Accepted PR 👍

@adamralph
Copy link
Contributor Author

@mellinoe that test was using the wrong variable for assertion which is why it was passing. I've fixed it in another PR #32

@DamianEdwards
Copy link
Member

:shipit:

@jeffdoolittle
Copy link

👍

@anaisbetts
Copy link

Fuck yeah @adamralph

@NickMOrlando
Copy link

👍

@Mpdreamz
Copy link
Contributor

💥 Immortalised yourself here @adamralph 👍

@juanfranblanco
Copy link

Awesome you are the first

@charleslbryant
Copy link

Sweet

@tiagobabo
Copy link

👍

@tugberkugurlu
Copy link

💥 🎆

@ciriarte
Copy link

👍 fantastic!

@erinpagemd
Copy link

👍

@AlexZeitler
Copy link

Holy shit - it happened 🙈🙏

@haacked
Copy link

haacked commented Nov 12, 2014

selfie-0

@dennisdoomen
Copy link

Congrats @adamralph. Let's drink on it next week!

@DavidChristiansen
Copy link

Woot @adamralph - You the man!! That's at least two beers for you next week! (@ buildstuff.lt)

@glennblock
Copy link

Nice job @adamralph!

@khellang
Copy link
Member

Yay! 😁👍

Yay

@andrewconnell
Copy link

No freaking way... give that man a Surface Pro 3 & XBOX One!

xhwl9dq

No more...

@SharePointing
Copy link

I think thus fits the bill for:

http://m.youtube.com/watch?v=xjzzLelV0Y0

Eh @andrewconnell ?

@LoungeFlyZ
Copy link

its-working-its-working

@VesaJuvonen
Copy link

change-is-inevitable

@georgeracu
Copy link

👍

@jbuiss0n
Copy link

Awesome !

@staticvoidmaine
Copy link

So great 👍

@Zimmergren
Copy link

Nicely done @adamralph :-)

@ezechibritton
Copy link

@adamralph Simply awesome, you just earned your spot in history buddy. Can I name drop and say @adamralph was my team mate! :-)

@odiszapc
Copy link

Fuck yeah? Fuck yeahhhh!!!!!!!!!!11

@gy
Copy link

gy commented Nov 21, 2014

Awesome @adamralph 💯

@manigandham
Copy link

Great to see Microsoft embracing open-source completely, this is fantastic! Great job getting things started @adamralph!

@kunjee17
Copy link

@adamralph man, you did it... Thanks and Thanks to team dot net for all this OSS work. +1

@phillip-haydon
Copy link

image

image

image

Never thought I would see the day.

@henriksen
Copy link

Nice! Well done!

@vidyavardhan
Copy link

👍

@fagnercarvalho
Copy link

This is historical! 😃

@santosoide
Copy link

Congratulations 👍

@AnthonyDGreen
Copy link

Couldn't resist, LGTM!
#NDCOslo

pgavlin added a commit to pgavlin/corefx that referenced this pull request Sep 22, 2015
sepidehkh added a commit to sepidehkh/corefx that referenced this pull request Feb 3, 2016
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.