-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Fix vector tests to work on non en-US culture machines #31
Conversation
LGTM. running this through our CI |
Is that officially the first community pull request? If yes, will that be the first ACCEPTED community pull request? 👍 |
@MaximRouiller Yes. |
👍 |
Awesome - thank you! |
Great catch, thanks for submitting this. I believe there is an analogous test in Vector4Tests.cs that needs to be changed, as well (it also tests this same case for Vector4). 👍 |
@adamralph I was hoping this would be a "Remove all regions" troll PR. Much disappoint. |
👍 congratulations |
congrats! |
Woot |
Awesome dude! |
Haha awesome! First Accepted PR 👍 |
👍 |
Fuck yeah @adamralph |
👍 |
💥 Immortalised yourself here @adamralph 👍 |
Awesome you are the first |
Sweet |
👍 |
💥 🎆 |
👍 fantastic! |
👍 |
Holy shit - it happened 🙈🙏 |
Congrats @adamralph. Let's drink on it next week! |
Woot @adamralph - You the man!! That's at least two beers for you next week! (@ buildstuff.lt) |
Nice job @adamralph! |
I think thus fits the bill for: http://m.youtube.com/watch?v=xjzzLelV0Y0 Eh @andrewconnell ? |
👍 |
Awesome ! |
So great 👍 |
Nicely done @adamralph :-) |
@adamralph Simply awesome, you just earned your spot in history buddy. Can I name drop and say @adamralph was my team mate! :-) |
Fuck yeah? Fuck yeahhhh!!!!!!!!!!11 |
Awesome @adamralph 💯 |
Great to see Microsoft embracing open-source completely, this is fantastic! Great job getting things started @adamralph! |
@adamralph man, you did it... Thanks and Thanks to team dot net for all this OSS work. +1 |
Nice! Well done! |
👍 |
This is historical! 😃 |
Congratulations 👍 |
Couldn't resist, LGTM! |
Clean up TCP{Client,Listener}.
Xml with cli in progress
This fixes the following test failure (on my de-CH machine)
After the change the build succeeds.