Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert System.Runtime.InteropServices.RuntimeInformation to a fat package #17035

Closed
ericstj opened this issue Apr 19, 2016 · 7 comments
Closed
Assignees
Milestone

Comments

@ericstj
Copy link
Member

ericstj commented Apr 19, 2016

This enables us to package it such that it works on desktop without a lineup. Desktop shouldn't need a lineup and this is one package that was causing it to be required. Let's double check all packages as part of this work to ensure they don't need a lineup for desktop.

@ericstj ericstj self-assigned this Apr 19, 2016
@weshaggard weshaggard changed the title Convert System.Runtime.InteropServices.WindowsRuntime to a fat package Convert System.Runtime.InteropServices.RuntimeInformation to a fat package Apr 19, 2016
@ericstj
Copy link
Member Author

ericstj commented Apr 20, 2016

Another thing I'm noticing while looking at this is some packages have a specific desktop asset and RID specific assets but don't always put the desktop asset in the RID folder. As a result we could get different implementation (wrong) when resolving for desktop and providing a rid like "win7" or "win8". I think we should try and make all the desktop assets behave the same.

If the package is fat, duplicate the desktop asset in the RID and RID-less folder.

@davidfowl
Copy link
Member

davidfowl commented Apr 23, 2016

/cc @emgarten

This is interesting because it means you can end up with different nuget selection on packages.config and project.json (but you could argue that's expected)

@ericstj
Copy link
Member Author

ericstj commented Apr 25, 2016

Yeah, that's expected. I'm making changes to our packages to ensure that any packages that do support project-types that are still on packages.config get the same asset (by copying that asset into lib, so long as it doesn't require RID specific selection on those projects)

@pranavkm
Copy link
Contributor

@ericstj - is this not going to be fixed for RTM?

@ericstj
Copy link
Member Author

ericstj commented May 17, 2016

It's already fixed in the RC3 packages.

@pranavkm
Copy link
Contributor

Ok. I was confused by the 1.1.0 milestone attached to this work item.

@ericstj
Copy link
Member Author

ericstj commented May 17, 2016

That's odd, it was set to 1.0.0-rtm on 28 days ago, and I don't see anything that changed it to 1.1.0. I have changed it back.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants