Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Assembly.GetEntryAssembly() back to the contracts #15566

Closed
davidfowl opened this issue Oct 26, 2015 · 14 comments
Closed

Add Assembly.GetEntryAssembly() back to the contracts #15566

davidfowl opened this issue Oct 26, 2015 · 14 comments
Labels
api-approved API was approved in API review, it can be implemented
Milestone

Comments

@davidfowl
Copy link
Member

We want to be able to implement IApplicationEnvironment which has an ApplicationName which is the name of the application being run. This is impossible to do today without writing a custom host or accessing it via mscorlib directly.

@davidfowl
Copy link
Member Author

/cc @nguerrera

@davidfowl
Copy link
Member Author

@nguerrera This is done right?

@nguerrera
Copy link
Contributor

@davidfowl No, it isn't.

@nguerrera nguerrera assigned weshaggard and unassigned nguerrera Nov 3, 2015
@nguerrera
Copy link
Contributor

cc @weshaggard

@weshaggard weshaggard assigned pallavit and unassigned weshaggard Nov 3, 2015
@weshaggard
Copy link
Member

@pallavit can you have a look at this.

@weshaggard
Copy link
Member

@davidfowl how does this relate to https://github.com/dotnet/corefx/issues/4314? While in I'm in favor of adding this API as well I'm trying to understand your scenarios, do you have other scenarios outside of the application name?

@davidfowl
Copy link
Member Author

Not really, if we added the other thing and make this the default implementation (and made the name settable). It would enable the scenario I'm after.

@davidfowl
Copy link
Member Author

Can I get an update on this API?

@pallavit
Copy link
Contributor

pallavit commented Dec 8, 2015

/cc: @weshaggard , @terrajobst We have been looking at the API additions collectively and this is in the list of the things. I am not sure of the timelines yet though, as the implementation work has not yet started. I am hoping you are mostly unblocked with dotnet/corefx#4314 and this is only for the matter of completeness. Let me know if that is not the case.

@weshaggard
Copy link
Member

Yes this is included but we should try to do this as a one-off to help unblock some cli scenarios.

pallavit referenced this issue in pallavit/corefx Dec 17, 2015
Expose Assembly.GetEntryAssembly and TypeInfo.IsEquivalentTo() in System.Reflection.
Fixes issues #4146 , #2101
pallavit referenced this issue in pallavit/corefx Dec 17, 2015
Expose Assembly.GetEntryAssembly and TypeInfo.IsEquivalentTo() in System.Reflection.
Fixes issues #4146 , #2101
pallavit referenced this issue in pallavit/corefx Dec 21, 2015
Expose Assembly.GetEntryAssembly and TypeInfo.IsEquivalentTo() in System.Reflection.
Fixes issues #4146 , #2101
pallavit referenced this issue in pallavit/corefx Dec 21, 2015
Expose Assembly.GetEntryAssembly and TypeInfo.IsEquivalentTo() in System.Reflection.
Fixes issues #4146 , #2101
@pallavit
Copy link
Contributor

This is exposed via dotnet/corefx#5029

@pallavit pallavit removed their assignment Dec 22, 2015
@NTaylorMullen
Copy link

@pallavit Question, this seems to only be exposed in netstandard1.5. Is there a reason this can't also be exposed for netstandard1.0 and netstandard1.3?

@weshaggard
Copy link
Member

It cannot be exposed in an earlier netstandard because some of the platforms that target those do not support it (i.e. WP, UWP).

@NTaylorMullen
Copy link

Ah, I see. Thanks @weshaggard

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rc2 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-approved API was approved in API review, it can be implemented
Projects
None yet
Development

No branches or pull requests

6 participants